Re: [quicwg/base-drafts] First pass at 7, 14, and 30-bit varint packet numbers (#1334)

Brian Trammell <notifications@github.com> Thu, 03 May 2018 17:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A07CD12EA8D for <quic-issues@ietfa.amsl.com>; Thu, 3 May 2018 10:29:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.008
X-Spam-Level:
X-Spam-Status: No, score=-8.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tOxxfg9Dt2UD for <quic-issues@ietfa.amsl.com>; Thu, 3 May 2018 10:29:15 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E495D12E8CA for <quic-issues@ietf.org>; Thu, 3 May 2018 10:29:14 -0700 (PDT)
Date: Thu, 03 May 2018 10:29:13 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1525368553; bh=fOFaWkXoPLD14uDax4UHSyw1CoCWI9wBZF0Ls0n/C40=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=gqVTNrSkU7fujxe9evV+RitAZ5VwZhT8XktJO6o2oKxMM6eWhcZw7hdYMGrxyzQzV qRDDdsA0tIbwoGunFzTklnYcpoH+5eRbhrkAyjzbzc2s5e16P9wOqjRPYy2wY6T4Y7 8bABvfecW+Y6HizW0hvaL9PmYU+wl+L6mgKJIkNE=
From: Brian Trammell <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abff1ee54e89489cf5cd73251f0bd3a4d0d9c1fe9d92cf00000001170308e992a169ce13113a51@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1334/review/117358228@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1334@github.com>
References: <quicwg/base-drafts/pull/1334@github.com>
Subject: Re: [quicwg/base-drafts] First pass at 7, 14, and 30-bit varint packet numbers (#1334)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aeb46e9cd17d_79b63fe2f116ef7c2096d6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: britram
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vTchOU4aSxH2sq-VieHmdhddbRo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 May 2018 17:29:17 -0000

britram commented on this pull request.



> +short packet header, the number of significant bits are encoded in the most
+significant two bits of the first octet of the encoded packet number:
+
+| First octet pattern | Encoded Length | Bits Present |
+|:--------------------|:---------------|:-------------|
+| 0b0xxxxxxx          | 1 octet        | 7            |
+| 0b10xxxxxx          | 2              | 14           |
+| 0b11xxxxxx          | 4              | 30           |
+
+Note that these encodings are similar to those in {{integer-encoding}}, but
+use different values.
+
+The encoded packet number is protected as described in Section 5.6 {{QUIC-TLS}}.
+Protection of the packet number is removed prior to recovering the full packet
+number.The full packet number is reconstructed at the receiver based on the
+value of the most significant two bits in the first octet (to determine the

yep, this is better.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1334#discussion_r185879074