IETF Logo Mail Archive

Re: [quicwg/base-drafts] Retransmit server initial upon second Initial (#3080)

Martin Thomson <notifications@github.com> Mon, 14 October 2019 22:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 36CA2120894 for <quic-issues@ietfa.amsl.com>; Mon, 14 Oct 2019 15:46:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hrWa1QeANzVM for <quic-issues@ietfa.amsl.com>; Mon, 14 Oct 2019 15:46:45 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5BD5D120893 for <quic-issues@ietf.org>; Mon, 14 Oct 2019 15:46:45 -0700 (PDT)
Received: from github-lowworker-2ef7ba1.ac4-iad.github.net (github-lowworker-2ef7ba1.ac4-iad.github.net [10.52.16.66]) by smtp.github.com (Postfix) with ESMTP id 81F492C0E56 for <quic-issues@ietf.org>; Mon, 14 Oct 2019 15:46:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571093204; bh=RQGpph+qQfdt9oEpzEkIZ8WYlAmAvTKFSGyxk5y1n6Y=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Eq8qsgUz8Gr1D6UcBZ1zz2YjMjN9uvqpJbF7ofOsYI6pDA9cEo9nSZWZ32Ppj/GTK O14O1QAEeXBSkk5MpXFuJw/Pdb91jybF30daNd76IjEWZN586Bj4AUeQcQasZ56n3e m1PDZ93++jcxhtFWF+iGaY1dOdri+0CEbWEuBXQM=
Date: Mon, 14 Oct 2019 15:46:44 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2OUHNNVSXCHZOTBKN3WI5WJEVBNHHB37QS2E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3080/review/301575783@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3080@github.com>
References: <quicwg/base-drafts/pull/3080@github.com>
Subject: Re: [quicwg/base-drafts] Retransmit server initial upon second Initial (#3080)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da4fad4735f8_64603f97738cd9681195fe"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vU0H5sk9oRSCNL0Ahw-n-Ms675k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Oct 2019 22:46:47 -0000

martinthomson commented on this pull request.

I'm ambivalent on this one, but this doesn't seem like it would be hurtful.

> @@ -508,6 +508,12 @@ until it is certain that the server has finished its address validation
 probe timer if the client has not received an acknowledgement for one of its
 Handshake or 1-RTT packets.
 
+When a server receives duplicate Initial CRYPTO data when there
+is unacknoweledged Initial CRYPTO data, it can assume the client did not

```suggestion
is unacknowledged Initial CRYPTO data, it can assume the client did not
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3080#pullrequestreview-301575783

v2.19.0 | Report a Bug | By Email