Re: [quicwg/base-drafts] enforce the active_connection_id_limit (#3201)

Marten Seemann <notifications@github.com> Mon, 18 November 2019 09:36 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 659961208F2 for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 01:36:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.596
X-Spam-Level:
X-Spam-Status: No, score=-1.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KeZIL0QUGKOt for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 01:36:13 -0800 (PST)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B9D3120902 for <quic-issues@ietf.org>; Mon, 18 Nov 2019 01:36:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=IfLljeXSbH4MB3gE2xaSoudeqSaFLPapu70CArxd+sU=; b= PUwow9fWwHINfvCiE7CvKZYtvOG84KEkzzgcifvp90ZkqglsolLywbETXxDRnNtT WMNA972Fj+rvUQ6wa33r104CzVLFG3dHKAUmCSxIyegwRyXdQ0QQjgT6bCt8E3z5 phanoBqMVHVa2Q9VsLy4lpKP2XyPjDE1U/OeODIOsr8=
Received: by filter1355p1las1.sendgrid.net with SMTP id filter1355p1las1-11390-5DD2660C-E 2019-11-18 09:36:12.520091865 +0000 UTC m=+215993.220357771
Received: from github-lowworker-f144ac1.va3-iad.github.net (unknown [140.82.115.0]) by ismtpd0033p1iad2.sendgrid.net (SG) with ESMTP id duCFVwZkTH-zGP7BO4Er0A for <quic-issues@ietf.org>; Mon, 18 Nov 2019 09:36:12.397 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-f144ac1.va3-iad.github.net (Postfix) with ESMTP id 3C9B292078C for <quic-issues@ietf.org>; Mon, 18 Nov 2019 01:36:12 -0800 (PST)
Date: Mon, 18 Nov 2019 09:36:12 +0000
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK26WTSPXJ3DCMFUR7V336MIZEVBNHHB532IFY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3201/review/318197112@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3201@github.com>
References: <quicwg/base-drafts/pull/3201@github.com>
Subject: Re: [quicwg/base-drafts] enforce the active_connection_id_limit (#3201)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd2660c3b4a5_4eb33fb2c72cd9683323e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3m10VmX7mVvKWp26tczO5O95f/cUNCIZRI3C 1KDoDVFi8SLWut2Ads6oePH4abeqWptcctS8pp1/THha9OhZZwp7EosXRFmXoP3cl17h0/T3NLAHhx 9PT0X+Kdb/yNAHm+UY9fV6FkplhLBSdd2+w+8VSuxTIq6nqUnqCK/g8g107LvaYagDsK9QICY/gk3k Y=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vX3p_YF36Bs5ObTIXgAUuieZ3Mw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Nov 2019 09:36:20 -0000

marten-seemann commented on this pull request.



> @@ -4590,8 +4595,14 @@ preferred_address (0x000d):
 active_connection_id_limit (0x000e):
 
 : The maximum number of connection IDs from the peer that an endpoint is willing
-  to store. This value includes only connection IDs sent in NEW_CONNECTION_ID
-  frames. If this parameter is absent, a default of 0 is assumed.
+  to store. This value includes connection IDs sent in NEW_CONNECTION_ID frames,
+  the connection ID used during the handshake as well as the connection ID
+  provided in the preferred_address transport parameter.
+  Unless a zero-length connection ID is being used, the value of the
+  active_connection_id_limit parameter MUST be no less than 2. If this
+  transport parameter is absent, a default of 2 is assumed.
+  When a zero-length connection ID is being used, the active_connection_id_limit
+  parameter MUST NOT be sent.

Can you elaborate which part you find detrimental?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3201#discussion_r347275680