IETF Logo Mail Archive

Re: [quicwg/base-drafts] minimum payload size requirement creates awkward special case (#2049)

Nick Banks <notifications@github.com> Sun, 25 November 2018 16:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E747C130DC5 for <quic-issues@ietfa.amsl.com>; Sun, 25 Nov 2018 08:40:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j3AJpIPa0ZAF for <quic-issues@ietfa.amsl.com>; Sun, 25 Nov 2018 08:40:08 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8B5D912EB11 for <quic-issues@ietf.org>; Sun, 25 Nov 2018 08:40:08 -0800 (PST)
Date: Sun, 25 Nov 2018 08:40:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543164006; bh=ObKjt2fx6jVUTsHhxYk0LcEakmC1mMu8ZWOWfAlsB1U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=AucFaxKxuoJJu+lp79DBWNjOT6qv1KB1cdCwwgW32xEc5E75h7WSY0s4VusJ3JPEu ntmESKU5Qm0VwuQFsBQ3xspLTbWkl+VULOFi/SgS34tenJQ7rjUtuPZye/PcjSP9Q3 weKYwfHCg0iXS3/Ikod7Yk4VbrLNpPj8zYUWj1bI=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5a07fa8d12a14f10d687c652562377bce6e9de8092cf000000011812926692a169ce16e4137a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2049/441453821@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2049@github.com>
References: <quicwg/base-drafts/issues/2049@github.com>
Subject: Re: [quicwg/base-drafts] minimum payload size requirement creates awkward special case (#2049)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfad0661ab83_1a0e3ff4e64d45c02782311"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vYJIWERx4lamsEHTUqbfMxK9Rok>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Nov 2018 16:40:11 -0000

I think this can be trivially solved by updating your logic that decides if the length should be included in the STREAM frame. When writing the frame to the packet buffer, if the length of the stream data is less than 4 bytes just always include the length. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2049#issuecomment-441453821

v2.35.0 | Report a Bug | By Email | System Status