Re: [quicwg/base-drafts] Mandatory distinction between token types (#3128)

MikkelFJ <notifications@github.com> Thu, 12 March 2020 16:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 610DD3A0D28 for <quic-issues@ietfa.amsl.com>; Thu, 12 Mar 2020 09:26:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6fHlNrWm_Q9w for <quic-issues@ietfa.amsl.com>; Thu, 12 Mar 2020 09:26:19 -0700 (PDT)
Received: from out-13.smtp.github.com (out-13.smtp.github.com [192.30.254.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F1E2B3A0D24 for <quic-issues@ietf.org>; Thu, 12 Mar 2020 09:26:18 -0700 (PDT)
Date: Thu, 12 Mar 2020 09:26:17 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584030378; bh=1rMMmoTy5CC7d6Hebm1xYimAdUPzVJMNAAwv2IXemR0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DzINhW2A1U2vLjXoJ7//HyEgDrENhMT8MSI3McuLts1D2Vt966ZV+43BRmrwdOwrZ E1fxjm9XpWkky+tsIq1o6hCgoGPYVjGhJoU/8xsF/7H1XhbUPewxYkokdd0S+0HihI ZquHtVkYKIh/nOh9nwOtKW+yJ46oH5BEO8Wmi7ZI=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYSURRIEDKYW2APKSN4OZB2TEVBNHHB43A2P4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3128/review/373709680@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3128@github.com>
References: <quicwg/base-drafts/pull/3128@github.com>
Subject: Re: [quicwg/base-drafts] Mandatory distinction between token types (#3128)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e6a62a9ca3f3_1cbd3fc16fccd95c11945e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vZ30PZvX5u0I_FVKqcNYdqzZV1w>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Mar 2020 16:26:20 -0000

mikkelfj commented on this pull request.



>  Unlike the token that is created for a Retry packet, there might be some time
 between when the token is created and when the token is subsequently used.
 Thus, a token SHOULD have an expiration time, which could be either an explicit
 expiration time or an issued timestamp that can be used to dynamically calculate
 the expiration time.  A server can store the expiration time or include it in an
 encrypted form in the token.
 
+A token issued with NEW_TOKEN MUST NOT include information that would allow
+values to be linked by an on-path observer to the connection on which it was

Note that we have inconsistent terminology: and "off-path" attack can still read packets in the threat model, but here an "on-path" observer can see packets presumably as opposed to "off-path".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3128#pullrequestreview-373709680