Re: [quicwg/base-drafts] Persistent congestion pseudocode to match text (#4010)

[Martin Thomson <[e-mail]>]

@martinthomson commented on this pull request.



> @@ -1514,6 +1517,7 @@ variables as follows:
    bytes_in_flight = 0
    congestion_recovery_start_time = 0
    ssthresh = infinite
+   first_rtt_sample = never

Yeah, but that means understanding that 0 is not a valid time, and I don't know if that is true.  But I guess that is the convention, so I'll fix it.

>       pto = smoothed_rtt + max(4 * rttvar, kGranularity) +
        max_ack_delay
-     congestion_period = pto * kPersistentCongestionThreshold
+     pc_period = pto * kPersistentCongestionThreshold
+
+     // Only look for persistent congestion if the period
+     // starts after getting the first RTT sample.
+     assert(first_rtt_sample is not never)
+     if (largest_lost.time_sent - pc_period > first_rtt_sample):

`largest_lost` is the name of the variable we have.  This says that the span of length pc_period that ends at the time that the largest lost was sent must start after we first got an RTT sample.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4010#discussion_r471900059