Re: [quicwg/base-drafts] Make transport parameters varint (#3087)
Martin Thomson <notifications@github.com> Tue, 15 October 2019 23:19 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 795C91207FC for <quic-issues@ietfa.amsl.com>; Tue, 15 Oct 2019 16:19:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AMy74iG52KwP for <quic-issues@ietfa.amsl.com>; Tue, 15 Oct 2019 16:19:07 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 83BBC120104 for <quic-issues@ietf.org>; Tue, 15 Oct 2019 16:19:07 -0700 (PDT)
Date: Tue, 15 Oct 2019 16:19:06 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571181546; bh=wXV2VPSDlk1HwPIgCS7VaWLyAE0/hmEC8CPjt7h0oyE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eZYvdFB8YHHfp3Gfj4uwPuALhjylOavyVR1+WMab1jXjtd+oxq+ZSPrQ9HEVWwJEz MjibFPKU9X8vITs3/5YSma0hLH2KGKXkkHfuxIJ3re1m+wkGaZvhms7bKCYy1OHDbG sdohYVWd5GLJrTJSqDw/DGhZ5eSwn1K/cbsMTJ44=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ3X3EUVRXR5ECKA3F3WOKHVEVBNHHB4KOWU4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3087/review/302248399@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3087@github.com>
References: <quicwg/base-drafts/pull/3087@github.com>
Subject: Re: [quicwg/base-drafts] Make transport parameters varint (#3087)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da653ea7bf31_65523f9c8eecd960303254"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vdY14-EbbfQlQZS3kaFeM0umYoA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Oct 2019 23:19:10 -0000
martinthomson commented on this pull request. This seems pretty clear, though like others I'm not convinced of the necessity. > - struct { - opaque ipv4Address[4]; - uint16 ipv4Port; - opaque ipv6Address[16]; - uint16 ipv6Port; - opaque connectionId<0..20>; - opaque statelessResetToken[16]; - } PreferredAddress; + 0 1 2 3 + 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| IPv4 Address (32) | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| IPv4 Port (16) | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| IPv6 Address (128) ... Rather than this taking two lines, would you have this take 5 lines, or 8? > -| 0x000c | disable_active_migration | {{transport-parameter-definitions}} | -| 0x000d | preferred_address | {{transport-parameter-definitions}} | -| 0x000e | active_connection_id_limit | {{transport-parameter-definitions}} | +| Value | Parameter Name | Specification | +|:------|:----------------------------|:------------------------------------| +| 0x0 | original_connection_id | {{transport-parameter-definitions}} | +| 0x1 | idle_timeout | {{transport-parameter-definitions}} | +| 0x2 | stateless_reset_token | {{transport-parameter-definitions}} | +| 0x3 | max_packet_size | {{transport-parameter-definitions}} | +| 0x4 | initial_max_data | {{transport-parameter-definitions}} | +| 0x5 | initial_max_stream_data_bidi_local | {{transport-parameter-definitions}} | +| 0x6 | initial_max_stream_data_bidi_remote | {{transport-parameter-definitions}} | +| 0x7 | initial_max_stream_data_uni | {{transport-parameter-definitions}} | +| 0x8 | initial_max_streams_bidi | {{transport-parameter-definitions}} | +| 0x9 | initial_max_streams_uni | {{transport-parameter-definitions}} | +| 0xA | ack_delay_exponent | {{transport-parameter-definitions}} | HeX IS LOWeRCaSe ```suggestion | 0xa | ack_delay_exponent | {{transport-parameter-definitions}} | ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3087#pullrequestreview-302248399
- [quicwg/base-drafts] Make transport parameters va… David Schinazi
- Re: [quicwg/base-drafts] Make transport parameter… ekr
- Re: [quicwg/base-drafts] Make transport parameter… David Schinazi
- Re: [quicwg/base-drafts] Make transport parameter… Marten Seemann
- Re: [quicwg/base-drafts] Make transport parameter… David Schinazi
- Re: [quicwg/base-drafts] Make transport parameter… Mike Bishop
- Re: [quicwg/base-drafts] Make transport parameter… Martin Thomson
- Re: [quicwg/base-drafts] Make transport parameter… David Schinazi
- Re: [quicwg/base-drafts] Make transport parameter… David Schinazi