Re: [quicwg/base-drafts] Replace remove() with setting to null (#2987)
Martin Thomson <notifications@github.com> Mon, 26 August 2019 01:10 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA3F4120041 for <quic-issues@ietfa.amsl.com>; Sun, 25 Aug 2019 18:10:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vbn6bPPXRGlo for <quic-issues@ietfa.amsl.com>; Sun, 25 Aug 2019 18:10:38 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 20F6612001E for <quic-issues@ietf.org>; Sun, 25 Aug 2019 18:10:38 -0700 (PDT)
Date: Sun, 25 Aug 2019 18:10:37 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566781837; bh=+SDX8s8q7xH5fW3AFW+YZ0DCu5SiH/pnc08aWOvZumg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pD8mLG7dxfs1nMR52iEUjSEvS01oUR9zbtR3zl/9Lf+Zb9G0vKilwTExtMWfMAZBy QulfGn7zVX7/U3tjauH20o5qw9wEB7jten/7Y3yTe8cIj1nWga5ncw/tHwm6upAY4v HSG8hwNVwtEJ2l7iCQlw0oEIjzb4HRLwKQ0ufFME=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7LSEL4FM4STXP3CIN3OBSA3EVBNHHBZYSIIE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2987/review/279365304@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2987@github.com>
References: <quicwg/base-drafts/pull/2987@github.com>
Subject: Re: [quicwg/base-drafts] Replace remove() with setting to null (#2987)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d63318d3381e_3a0e3fb4f2ecd95c206746"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vhMtrFmqmByjJo1QF8cl1NJZBo4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Aug 2019 01:10:40 -0000
martinthomson commented on this pull request.
On line 1098, where it says:
```
if (sent_packets[pn_space][ack.largest_acked] &&
IncludesAckEliciting(newly_acked_packets)):
latest_rtt =
```
Should you instead be really clear and say:
```
if (sent_packets[pn_space][ack.largest_acked] != null &&
IncludesAckEliciting(newly_acked_packets)):
latest_rtt =
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2987#pullrequestreview-279365304
- [quicwg/base-drafts] Replace remove() with settin… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… Martin Thomson
- Re: [quicwg/base-drafts] Replace remove() with se… Martin Thomson
- Re: [quicwg/base-drafts] Replace remove() with se… MikkelFJ
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… Martin Thomson
- Re: [quicwg/base-drafts] Replace remove() with se… MikkelFJ
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… Jana Iyengar
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett