Re: [quicwg/base-drafts] Adjust autotuning recommendations (#2240)
ianswett <notifications@github.com> Fri, 21 December 2018 21:09 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 65D43130E1D for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 13:09:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jL7-oRapjLid for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 13:09:39 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D12A0130E74 for <quic-issues@ietf.org>; Fri, 21 Dec 2018 13:09:38 -0800 (PST)
Date: Fri, 21 Dec 2018 13:09:37 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545426577; bh=qiLCoTCXwn0vrgt01oxLPf9bij6TmuHHVQpisunjal4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YGqj/lqw+hBUKJl6iA7raSAu9sJT4im4l3j5K2005vAO7kLwAZxD2CRqlQp6M18ob yKzNVObxYFbn7wTUPpUv0cBhdN7yl+NN/GkaLGf4XRCKjeTlQVg4i5XbgQiNUKbeNZ CvxNlir0Gi4m0GS4cPuHH8iaUNoYcSjSlRMC4h5M=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab84cad6685ce209afbad8fdcf792ed28008707a5f92cf000000011835189192a169ce17718705@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2240/review/187539327@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2240@github.com>
References: <quicwg/base-drafts/pull/2240@github.com>
Subject: Re: [quicwg/base-drafts] Adjust autotuning recommendations (#2240)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1d5691e8d2a_4093fa8ac4d45c4658ce"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vizWXrR815gqtBqQJt7AWDLC32E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2018 21:09:40 -0000
ianswett approved this pull request. > advertised additional credit based on a round-trip time estimate and the rate at which the receiving application consumes data, similar to common TCP -implementations. +implementations. Sending frames related to flow control only when there are +other frames to send or when a peer is blocked ensures that flow control doesn't It's an optimization I've suggested a few times to ensure sending more frequent updates doesn't have substantial overhead. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2240#pullrequestreview-187539327
- [quicwg/base-drafts] Adjust autotuning recommenda… Martin Thomson
- Re: [quicwg/base-drafts] Adjust autotuning recomm… Marten Seemann
- Re: [quicwg/base-drafts] Adjust autotuning recomm… Martin Thomson
- Re: [quicwg/base-drafts] Adjust autotuning recomm… Marten Seemann
- Re: [quicwg/base-drafts] Adjust autotuning recomm… Martin Thomson
- Re: [quicwg/base-drafts] Adjust autotuning recomm… Marten Seemann
- Re: [quicwg/base-drafts] Adjust autotuning recomm… MikkelFJ
- Re: [quicwg/base-drafts] Adjust autotuning recomm… janaiyengar
- Re: [quicwg/base-drafts] Adjust autotuning recomm… ianswett
- Re: [quicwg/base-drafts] Adjust autotuning recomm… janaiyengar
- Re: [quicwg/base-drafts] Adjust autotuning recomm… janaiyengar
- Re: [quicwg/base-drafts] Adjust autotuning recomm… janaiyengar
- Re: [quicwg/base-drafts] Adjust autotuning recomm… Martin Thomson
- Re: [quicwg/base-drafts] Adjust autotuning recomm… Martin Thomson