Re: [quicwg/base-drafts] MinRTT for the congestion control context (#2919)

Eric Kinnear <notifications@github.com> Sun, 21 July 2019 22:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A20AA120045 for <quic-issues@ietfa.amsl.com>; Sun, 21 Jul 2019 15:22:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id shyE1EIMD-cl for <quic-issues@ietfa.amsl.com>; Sun, 21 Jul 2019 15:22:43 -0700 (PDT)
Received: from out-14.smtp.github.com (out-14.smtp.github.com [192.30.254.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1264012001E for <quic-issues@ietf.org>; Sun, 21 Jul 2019 15:22:43 -0700 (PDT)
Date: Sun, 21 Jul 2019 15:22:42 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1563747762; bh=7lKs9g9vMVAPFUu6UlflTNxe/NZ4/mI+dI48tOP7tQI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ALw7RprhFCdadWR/++eMAKS1M4+vIROaeoqBX35upmTgaWdQ5TiBp2Ho1AZG4IFdm CQV/gS7pFn6cGK3rbjjuwdO0mtXlkjDtxcAcSJ/gZxp7r9c4gNW1goTGSx18wti71a APHLpnZ1oGJeQioBjeWsvO8KxjHLB/nz+NmBL7Sc=
From: Eric Kinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6QCAW63XM6UOANBD53IIMDFEVBNHHBYEA2AU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2919/review/264557064@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2919@github.com>
References: <quicwg/base-drafts/pull/2919@github.com>
Subject: Re: [quicwg/base-drafts] MinRTT for the congestion control context (#2919)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d34e5b2400e7_4fc03fda89ccd9601449951"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vkdFYQQdw7m8w1TT6ZMpR_1WqVQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jul 2019 22:22:45 -0000

erickinnear commented on this pull request.



> @@ -410,11 +417,11 @@ endpoint:
   min_rtt.  This limits the underestimation that a misreporting peer can cause
   to the smoothed_rtt.
 
-On the first RTT sample in a connection, the smoothed_rtt is set to the
-latest_rtt.
+On the first RTT sample in a congestion control context, the smoothed_rtt is

Elsewhere don’t we discuss resetting a congestion control context? It seems like that often lines up with a path, but they don’t have to be the same thing. It seems like you’re saying that RTT isn’t part of congestion control (which sounds totally valid but we then need some better way to word that)?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2919#discussion_r305638679