Date: Thu, 03 Oct 2019 16:57:02 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKYHROMQEL3VDAUHQIF3UPFV3EVBNHHB3NCBX4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3069/review/297209513@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3069@github.com>
References: <quicwg/base-drafts/pull/3069@github.com>
Subject: Re: [quicwg/base-drafts] ack-eliciting not ACK-eliciting (#3069)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5d968ace58d_4a933fc71b6cd96083754";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vmhVO6aSxIPoKGae3yfQlOl20_c>


----==_mimepart_5d968ace58d_4a933fc71b6cd96083754
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

janaiyengar approved this pull request.

One nit, but LGTM.

> @@ -190,6 +190,11 @@ QUIC packet:
 : A complete processable unit of QUIC that can be encapsulated in a UDP
   datagram.  Multiple QUIC packets can be encapsulated in a single UDP datagram.
 
+Ack-eliciting Packet:
+
+: A QUIC packet that contains frames other than ACK and PADDING. These cause a
+  recipient to send an acknowledgment within the maximum ack delay.

```suggestion
  recipient to send an acknowledgment within its maximum ACK delay ({{transport-parameter-definitions}}).
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3069#pullrequestreview-297209513
----==_mimepart_5d968ace58d_4a933fc71b6cd96083754
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@janaiyengar</b> approved this pull request.</p>=0D
=0D
<p>One nit, but LGTM.</p><hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3069#discussi=
on_r331298572">draft-ietf-quic-transport.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -190,6 +190,11 @@ QUIC packet:=0D
 : A complete processable unit of QUIC that can be encapsulated in a UDP=0D=

   datagram.  Multiple QUIC packets can be encapsulated in a single UDP d=
atagram.=0D
 =0D
+Ack-eliciting Packet:=0D
+=0D
+: A QUIC packet that contains frames other than ACK and PADDING. These c=
ause a=0D
+  recipient to send an acknowledgment within the maximum ack delay.=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-  recipient to send an acknowledgment within =
the maximum ack delay.=0D
+  recipient to send an acknowledgment within its maximum ACK delay ({{tr=
ansport-parameter-definitions}}).=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3069?email_source=3Dnotifications&amp;email_token=3DA=
FTOJKZEHD75EWREFWEMW33QM2BE3A5CNFSM4I2OHT22YY3PNVWWK3TUL52HS4DFWFIHK3DMKJ=
SXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG3Q5KI#pullrequestreview-297209513=
">view it on GitHub</a>, or <a href=3D"https://github.com/notifications/u=
nsubscribe-auth/AFTOJK3U75FVB4ORCS2NOHLQM2BE3ANCNFSM4I2OHT2Q">mute the th=
read</a>.<img src=3D"https://github.com/notifications/beacon/AFTOJK2SSS46=
MBBCCJCN44DQM2BE3A5CNFSM4I2OHT22YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FE=
ZLWNFSXPKTDN5WW2ZLOORPWSZGOCG3Q5KI.gif" height=3D"1" width=3D"1" alt=3D""=
 /></p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3069?email_source=3D=
notifications\u0026email_token=3DAFTOJKZEHD75EWREFWEMW33QM2BE3A5CNFSM4I2O=
HT22YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC=
G3Q5KI#pullrequestreview-297209513",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3069?email_source=3Dno=
tifications\u0026email_token=3DAFTOJKZEHD75EWREFWEMW33QM2BE3A5CNFSM4I2OHT=
22YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG3=
Q5KI#pullrequestreview-297209513",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5d968ace58d_4a933fc71b6cd96083754--