Date: Wed, 27 May 2020 08:45:31 -0700
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK5GYSAMDD46Y7Q2U7V43JWBXEVBNHHCKKKFHA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3689/review/419358131@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3689@github.com>
References: <quicwg/base-drafts/pull/3689@github.com>
Subject: Re: [quicwg/base-drafts] Improve HTTP draft wording: frames carry
 identifier values (#3689)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5ece8b1be4b9c_65893fbce26cd96c1956e9";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vplpfEyU40-wZszuKs1CjEkWoCc>


----==_mimepart_5ece8b1be4b9c_65893fbce26cd96c1956e9
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@LPardue commented on this pull request.



> +frames indicating different identifiers, but the identifier in each frame
+MUST NOT be greater than the identifier in any previous frame, since clients
+might already have retried unprocessed requests on another connection.

I like the improvement but will highlight that this is an alternative way to present the described behaviour later on 

```
Like the server, the client MAY send subsequent GOAWAY
frames so long as the specified Push ID is strictly smaller than all previously
sent values.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3689#pullrequestreview-419358131
----==_mimepart_5ece8b1be4b9c_65893fbce26cd96c1956e9
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@LPardue</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3689#discussion_r431244781">draft-ietf-quic-http.md</a>:</p>
<pre style='color:#555'>&gt; +frames indicating different identifiers, but the identifier in each frame
+MUST NOT be greater than the identifier in any previous frame, since clients
+might already have retried unprocessed requests on another connection.
</pre>
<p>I like the improvement but will highlight that this is an alternative way to present the described behaviour later on</p>
<pre><code>Like the server, the client MAY send subsequent GOAWAY
frames so long as the specified Push ID is strictly smaller than all previously
sent values.
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3689#pullrequestreview-419358131">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK4MA3AIVQSMBA5HJBDRTUYRXANCNFSM4NIDL3PQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK7M62OMX3KGZSCN7MTRTUYRXA5CNFSM4NIDL3P2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODD7OLMY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3689#pullrequestreview-419358131",
"url": "https://github.com/quicwg/base-drafts/pull/3689#pullrequestreview-419358131",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5ece8b1be4b9c_65893fbce26cd96c1956e9--