Re: [quicwg/base-drafts] Fix persistent congestion period calculation (#3289)

ianswett <notifications@github.com> Fri, 06 December 2019 17:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 65810120086 for <quic-issues@ietfa.amsl.com>; Fri, 6 Dec 2019 09:26:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CpMD2svW8SW9 for <quic-issues@ietfa.amsl.com>; Fri, 6 Dec 2019 09:26:47 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E319112006D for <quic-issues@ietf.org>; Fri, 6 Dec 2019 09:26:46 -0800 (PST)
Received: from github-lowworker-943b171.ac4-iad.github.net (github-lowworker-943b171.ac4-iad.github.net [10.52.22.59]) by smtp.github.com (Postfix) with ESMTP id 2E4AF1C0C48 for <quic-issues@ietf.org>; Fri, 6 Dec 2019 09:26:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1575653206; bh=T3ay0R8RinRa2qebsv4KFnWYV6rdDrrlVECTXFZxIrI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZIJJBzeOBwoIZkEXsXeNHncaj9tCcoMkr+8+Y4ndDJUdFdJOoBr6+CgpjCL+Hrj0C FzemWONoP07kxgo31JFj9QFWhUyRlDvSjRr2lh+z0clM3MJ2W6sdxP8Wz1+stHyx8Y yDla2vT7uahSFP7z+ZfrysoQ6TfMPMDFeqYJfgqI=
Date: Fri, 06 Dec 2019 09:26:46 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5W3TXEW4BIAPQRPOF367A5NEVBNHHB7VUXZ4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3289/review/328347856@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3289@github.com>
References: <quicwg/base-drafts/pull/3289@github.com>
Subject: Re: [quicwg/base-drafts] Fix persistent congestion period calculation (#3289)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dea8f561ea21_527b3fbc888cd9602804e3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vrlqLrW4Hl424HT2SaDnqb53NhA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Dec 2019 17:26:48 -0000

ianswett commented on this pull request.



> @@ -735,7 +737,7 @@ illustrate persistent congestion:
 
 The first three packets are determined to be lost when the acknowlegement of
 packet 4 is received at t=8.  The congestion period is calculated as the time
-between the oldest and newest lost packets: (3 - 0) = 3.  The duration for
+between the oldest and newest lost packets: (7 - 0) = 7.  The duration for

Good point, my mistake on reading the example.  It's correct as is.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3289#discussion_r354945872