Re: [quicwg/base-drafts] receivers cannot enforce datagram padding (though they may drop) (#4254)

[Martin Thomson <[e-mail]>]

@martinthomson commented on this pull request.

This seems sensible.

> @@ -4085,6 +4085,13 @@ UDP datagrams MUST NOT be fragmented at the IP layer.  In IPv4
 ({{!IPv4=RFC0791}}), the DF bit MUST be set if possible, to prevent
 fragmentation on the path.
 
+Even though datagrams with certain properties are required to be padded, the
+size of the datagram is not authenticated, and endpoints might send coalesced
+packets after the handshake is confirmed (see {{packet-coalesce}}).  Therefore,

```suggestion
packets after the handshake is confirmed; see {{packet-coalesce}}.  Therefore,
```

> @@ -4085,6 +4085,13 @@ UDP datagrams MUST NOT be fragmented at the IP layer.  In IPv4
 ({{!IPv4=RFC0791}}), the DF bit MUST be set if possible, to prevent
 fragmentation on the path.
 
+Even though datagrams with certain properties are required to be padded, the

```suggestion
Datagrams are required to be padded under some conditions.  However, the
```

> +size of the datagram is not authenticated, and endpoints might send coalesced
+packets after the handshake is confirmed (see {{packet-coalesce}}).  Therefore,

```suggestion
size of the datagram is not authenticated.  Therefore,
```
I don't think that we need to call this out, but you can use the other suggestion if you prefer.

> @@ -4085,6 +4085,13 @@ UDP datagrams MUST NOT be fragmented at the IP layer.  In IPv4
 ({{!IPv4=RFC0791}}), the DF bit MUST be set if possible, to prevent
 fragmentation on the path.
 
+Even though datagrams with certain properties are required to be padded, the
+size of the datagram is not authenticated, and endpoints might send coalesced
+packets after the handshake is confirmed (see {{packet-coalesce}}).  Therefore,
+an endpoint MUST NOT close a connection when it receives a datagram that does
+not meet the padding requirements, though the endpoint MAY discard such

```suggestion
not meet size constraints, though the endpoint MAY discard such
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4254#pullrequestreview-512359586