Re: [quicwg/base-drafts] Add sample Retry packet (#3394)

Mike Bishop <notifications@github.com> Fri, 24 January 2020 17:55 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 86303120170 for <quic-issues@ietfa.amsl.com>; Fri, 24 Jan 2020 09:55:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WJs452UVYEUw for <quic-issues@ietfa.amsl.com>; Fri, 24 Jan 2020 09:55:23 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 47F95120114 for <quic-issues@ietf.org>; Fri, 24 Jan 2020 09:55:23 -0800 (PST)
Received: from github-lowworker-a6a2749.va3-iad.github.net (github-lowworker-a6a2749.va3-iad.github.net [10.48.16.62]) by smtp.github.com (Postfix) with ESMTP id 28E998C0604 for <quic-issues@ietf.org>; Fri, 24 Jan 2020 09:55:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579888522; bh=Tgw3a3x1RTdW/mGJi516VZ9Jq8DFtLoZPMjFaOsPdcI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fJ5Kg7+JI9g0KOEuoh41gbe6Avza97NhP/wAiIPMWj6Cj+Y8S2Tdkc9A9mik1RnYT +vPPHEfsIM1Fa6J57dP+lzUB6xgINAnUlWo6dr3+mhKtPYyTQApFij4vyaIo6nZVe8 cvQcJUSEWibwv+Lae9KbgwPbfQuOCqM6Jyf+GMDk=
Date: Fri, 24 Jan 2020 09:55:22 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2MT6K35OZ64P73OFV4HBRAVEVBNHHCCDJ2MI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3394/review/348123178@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3394@github.com>
References: <quicwg/base-drafts/pull/3394@github.com>
Subject: Re: [quicwg/base-drafts] Add sample Retry packet (#3394)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e2b2f8a1a2a9_3f463f9c304cd96421442d"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vsoyg82JM6iDpUV04eXsDaPj6w8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jan 2020 17:55:26 -0000

MikeBishop commented on this pull request.



> @@ -1973,6 +1973,19 @@ cd32f0b5004d9f5754c4f7f2d1f35cf3 f7116351c92b99c8ae5833225cb51855
 ~~~
 
 
+## Retry
+
+This shows a Retry packet that might be sent in response to the Initial packet
+in {{sample-client-initial}}. The integrity check includes the client-chosen
+connection ID value of 0x8394c8f03e515708, but that value is not transmitted

```suggestion
connection ID value of 0x8394c8f03e515708, but that value is not
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3394#pullrequestreview-348123178