Date: Fri, 24 Jan 2020 09:55:22 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK2MT6K35OZ64P73OFV4HBRAVEVBNHHCCDJ2MI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3394/review/348123178@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3394@github.com>
References: <quicwg/base-drafts/pull/3394@github.com>
Subject: Re: [quicwg/base-drafts] Add sample Retry packet (#3394)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e2b2f8a1a2a9_3f463f9c304cd96421442d";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vsoyg82JM6iDpUV04eXsDaPj6w8>


----==_mimepart_5e2b2f8a1a2a9_3f463f9c304cd96421442d
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

MikeBishop commented on this pull request.



> @@ -1973,6 +1973,19 @@ cd32f0b5004d9f5754c4f7f2d1f35cf3 f7116351c92b99c8ae5833225cb51855
 ~~~
 
 
+## Retry
+
+This shows a Retry packet that might be sent in response to the Initial packet
+in {{sample-client-initial}}. The integrity check includes the client-chosen
+connection ID value of 0x8394c8f03e515708, but that value is not transmitted

```suggestion
connection ID value of 0x8394c8f03e515708, but that value is not
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3394#pullrequestreview-348123178
----==_mimepart_5e2b2f8a1a2a9_3f463f9c304cd96421442d
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@MikeBishop</b> commented on this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3394#discussi=
on_r370763490">draft-ietf-quic-tls.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -1973,6 +1973,19 @@ cd32f0b5004d9f5754c=
4f7f2d1f35cf3 f7116351c92b99c8ae5833225cb51855=0D
 ~~~=0D
 =0D
 =0D
+## Retry=0D
+=0D
+This shows a Retry packet that might be sent in response to the Initial =
packet=0D
+in {{sample-client-initial}}. The integrity check includes the client-ch=
osen=0D
+connection ID value of 0x8394c8f03e515708, but that value is not transmi=
tted=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-connection ID value of 0x8394c8f03e515708, bu=
t that value is not transmitted=0D
+connection ID value of 0x8394c8f03e515708, but that value is not=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3394?email_source=3Dnotifications&amp;email_token=3DA=
FTOJKYZ2MR5LFYFAAJPPTTQ7MTQVA5CNFSM4KLAEDO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJ=
SXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCS77AKQ#pullrequestreview-348123178=
">view it on GitHub</a>, or <a href=3D"https://github.com/notifications/u=
nsubscribe-auth/AFTOJK7ZSWGT2CQH7HPQJL3Q7MTQVANCNFSM4KLAEDOQ">unsubscribe=
</a>.<img src=3D"https://github.com/notifications/beacon/AFTOJK34FIIJGN7P=
VQORCZLQ7MTQVA5CNFSM4KLAEDO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWN=
FSXPKTDN5WW2ZLOORPWSZGOCS77AKQ.gif" height=3D"1" width=3D"1" alt=3D"" /><=
/p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3394?email_source=3D=
notifications\u0026email_token=3DAFTOJKYZ2MR5LFYFAAJPPTTQ7MTQVA5CNFSM4KLA=
EDO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC=
S77AKQ#pullrequestreview-348123178",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3394?email_source=3Dno=
tifications\u0026email_token=3DAFTOJKYZ2MR5LFYFAAJPPTTQ7MTQVA5CNFSM4KLAED=
O2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCS7=
7AKQ#pullrequestreview-348123178",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5e2b2f8a1a2a9_3f463f9c304cd96421442d--