Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 649C73A092B for ; Wed, 13 May 2020 19:40:02 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -1.869 X-Spam-Level: X-Spam-Status: No, score=-1.869 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.173, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2bD6cVNZecue for ; Wed, 13 May 2020 19:40:00 -0700 (PDT) Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B7A3E3A0834 for ; Wed, 13 May 2020 19:40:00 -0700 (PDT) Received: from github-lowworker-25680bd.va3-iad.github.net (github-lowworker-25680bd.va3-iad.github.net [10.48.17.61]) by smtp.github.com (Postfix) with ESMTP id 272A6A06CA for ; Wed, 13 May 2020 19:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589423999; bh=ci1edDtvbucMgVzZDO3MDUHbL1zpjUGuESaSy80LSjg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Db8VHOaHKdf8IWtCc5MZWG6h/X+9IItsrnaO8Ey09rP6Y1dgELIYsExpMgDZ0RBGl 6xRHBFRtOPQ+iaCWMqI6PH3DLyXpfklArlFXX6itKmfnS8Iu7CXySmGpWxiYPSOVaS lImiotq9k/A7bPhv+h+QJC6WCRtI4t/AifojCoWY= Date: Wed, 13 May 2020 19:39:59 -0700 From: Marten Seemann Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] Add OnPacketReceived to pseudocode (#3653) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5ebcaf7f1718d_2fe43ff3f96cd96430873e"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: marten-seemann X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2020 02:40:03 -0000 ----==_mimepart_5ebcaf7f1718d_2fe43ff3f96cd96430873e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable @marten-seemann commented on this pull request.=0D =0D =0D =0D > @@ -1142,6 +1142,21 @@ Pseudocode for OnPacketSent follows:=0D SetLossDetectionTimer()=0D ~~~=0D =0D +## On Receiving a Packet=0D +=0D +When a packet is received, it may allow the server to send=0D +if the server was previously amplification limited.=0D +=0D +Psuedocode for OnPacketReceived follows:=0D =0D Pseudo, not psuedo. =0D =0D > @@ -1142,6 +1142,21 @@ Pseudocode for OnPacketSent follows:=0D SetLossDetectionTimer()=0D ~~~=0D =0D +## On Receiving a Packet=0D +=0D +When a packet is received, it may allow the server to send=0D +if the server was previously amplification limited.=0D +=0D +Psuedocode for OnPacketReceived follows:=0D +=0D +~~~=0D +OnPacketReceived(packet):=0D + // If this packet unblocks the server, arm the=0D + // timer to ensure forward progress resumes=0D + if (server was at anti-amplification limit):=0D + SetLossDetectionTimer()=0D + DecryptAndProcessFrames()=0D =0D This doesn=E2=80=99t seem to belong in recovery. I think you=E2=80=99re t= rying to point out that even undecryptable packets unblock the server, ri= ght?=0D =0D -- =0D You are receiving this because you are subscribed to this thread.=0D Reply to this email directly or view it on GitHub:=0D https://github.com/quicwg/base-drafts/pull/3653#pullrequestreview-4114260= 42= ----==_mimepart_5ebcaf7f1718d_2fe43ff3f96cd96430873e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

=0D

@marten-seemann commented on this pull request.

=0D =0D
=0D =0D

In draft-ietf-quic-recovery.md:

=0D 
> @@ -1142,6 +1142,21 @@ Pseudocode for OnPa=
cketSent follows:=0D
      SetLossDetectionTimer()=0D
 ~~~=0D
 =0D
+## On Receiving a Packet=0D
+=0D
+When a packet is received, it may allow the server to send=0D
+if the server was previously amplification limited.=0D
+=0D
+Psuedocode for OnPacketReceived follows:=0D
=0D

Pseudo, not psuedo.

=0D =0D
=0D =0D

In draft-ietf-quic-recovery.md:

=0D 
> @@ -1142,6 +1142,21 @@ Pseudocode for OnPa=
cketSent follows:=0D
      SetLossDetectionTimer()=0D
 ~~~=0D
 =0D
+## On Receiving a Packet=0D
+=0D
+When a packet is received, it may allow the server to send=0D
+if the server was previously amplification limited.=0D
+=0D
+Psuedocode for OnPacketReceived follows:=0D
+=0D
+~~~=0D
+OnPacketReceived(packet):=0D
+  // If this packet unblocks the server, arm the=0D
+  // timer to ensure forward progress resumes=0D
+  if (server was at anti-amplification limit):=0D
+    SetLossDetectionTimer()=0D
+  DecryptAndProcessFrames()=0D
=0D

This doesn=E2=80=99t seem to belong in recovery. I think you=E2=80=99r= e trying to point out that even undecryptable packets unblock the server,= right?

=0D =0D

&m= dash;
You are receiving this because you are subscribed to this thre= ad.
Reply to this email directly, view it on GitHub, or unsubscribe.3D""

=0D = ----==_mimepart_5ebcaf7f1718d_2fe43ff3f96cd96430873e--