Re: [quicwg/base-drafts] Pull some H2 content into the introduction (#2683)

MikkelFJ <notifications@github.com> Sat, 11 May 2019 06:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 831DA12007A for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 23:18:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.606
X-Spam-Level:
X-Spam-Status: No, score=-6.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5G8PuI1KH0GI for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 23:18:45 -0700 (PDT)
Received: from out-11.smtp.github.com (out-11.smtp.github.com [192.30.254.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1FB5912006F for <quic-issues@ietf.org>; Fri, 10 May 2019 23:18:45 -0700 (PDT)
Date: Fri, 10 May 2019 23:18:44 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557555524; bh=5kYe6JxrYoae3X32xyXRIOmAHCaQUhdjCRxXafGgf0U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=S4B5fSF9wzOyhwutcv0EaBs2TU43TegH6QAGLhrhNMEIa37QVmVycvVNOM8SQUnn6 tWI+jM4YKp3hQfYW0d249309fsu7CwO9OkHPWBut0OJ6mYFI27JUT1WSNKezePVsXl LzH7EQ/gDRzQEwFPAcqtA1JYZYa9FexL3cEy/1h0=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3VRKBFZUFWJK72AJV24ON4JEVBNHHBUX2AKM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2683/review/236364359@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2683@github.com>
References: <quicwg/base-drafts/pull/2683@github.com>
Subject: Re: [quicwg/base-drafts] Pull some H2 content into the introduction (#2683)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd6694440278_41783ff1c94cd95c93587"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vw1X1UN8ycM8r6UrNWiE2ZBP9x0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 11 May 2019 06:18:46 -0000

mikkelfj commented on this pull request.



> +  endpoint is discovered and a connection is established.
+- Stream Mapping and Usage ({{stream-mapping}}) describes the way QUIC streams
+  are used.
+- HTTP Framing Layer ({{http-framing-layer}}) describes the frames used on
+  most streams.
+- HTTP Request Lifecycle ({{http-request-lifecycle}}) describes how HTTP
+  semantics are expressed using frames.
+- Connection Closure ({{connection-closure}}) describes how connections are
+  terminated, either gracefully or abruptly.
+- Extensions to HTTP/3 ({{extensions}}) describes how new capabilities can be
+  added in future documents.
+- Error Handling ({{errors}}) describes how error conditions are handled and
+  expressed, either on a particular stream or for the connection as a whole.
+
+Readers familiar with HTTP/2 will find a more detailed comparison with that
+protocol in {{h2-considerations}}.

Well, understand the text, but it reads as if was written immediately after the first paragraph and then a lot of text was thrown in, end then "that protocol" stands dangling becuse it might mean either HTTP/1.1 or QUIC until you realize it cannot mean QUIC since QUIC didn't exist when HTTP/2 was written. So I merely suggest typing out HTTP/1.1 explicitly.

Also, my feedback have come across a bit grumpy, that was not the intention. I really do appreciate the extra clarifying text on this topic.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2683#discussion_r283084296