Re: [quicwg/base-drafts] Stream0 dt output for merge (#1450)
ekr <notifications@github.com> Mon, 25 June 2018 02:31 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A0944130E97 for <quic-issues@ietfa.amsl.com>; Sun, 24 Jun 2018 19:31:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0HHETcW3go_Y for <quic-issues@ietfa.amsl.com>; Sun, 24 Jun 2018 19:31:16 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 363CF130ECC for <quic-issues@ietf.org>; Sun, 24 Jun 2018 19:31:11 -0700 (PDT)
Date: Sun, 24 Jun 2018 19:31:10 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529893870; bh=vRrb+LoEk5N9uTamU5H8eA3ChuxFofYW3zAg5PSXxk0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CJNXx/HXBe9MgsVzxpHATEbSOUu4UqKj7nFS9xzsG7ZtGQXWToTAQ1czNAa/ivz8z vnzK7XlB6J4JTl3MsadE1loclSoabBcXvYEpg5PTVXkeU4aaSwMurlBMfDyGeEf6+Y BlGma0tEAaxZuwgmK5c4OTTjiSgnSsUklZKR0qoM=
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba3e56953967ab66bf1877456b12312a9e5da726292cf00000001174815ee92a169ce13d67a11@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1450/review/131452211@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1450@github.com>
References: <quicwg/base-drafts/pull/1450@github.com>
Subject: Re: [quicwg/base-drafts] Stream0 dt output for merge (#1450)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b3053ee6e08b_442e2ae49be98f544680a2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vw7kYxGPFll477UXBV5bi2GJebE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jun 2018 02:31:25 -0000
ekr commented on this pull request. > @@ -2849,43 +3014,19 @@ received packets in preference to packets received in the past. ### ACK Frames and Packet Protection -ACK frames that acknowledge protected packets MUST be carried in a packet that -has an equivalent or greater level of packet protection. - -Packets that are protected with 1-RTT keys MUST be acknowledged in packets that -are also protected with 1-RTT keys. - -A packet that is not protected and claims to acknowledge a packet number that -was sent with packet protection is not valid. An unprotected packet that -carries acknowledgments for protected packets MUST be discarded in its entirety. +ACK frames MUST only be carried in a packet that has the same packet I guess this may be a terminology issue. Let me try to explain what I am saying again. Say I receive the following packets 2:1, 2:2, 3:1, 3:3 where X:Y means "epoch X, PN Y". And then I screw up and ACK PN space 3 in epoch 2, so I send epoch=2: ACK[3, 1]. Technically, this means "Acknowledge PNs 3 and 1 in epoch 2", so it's not a cross-ACK from the receiver's perspective, but it *is* an ACK of an unsent packet, which at least at some times we have thought was grounds for tearing down a connection. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1450#discussion_r197666543
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… Kazuho Oku
- Re: [quicwg/base-drafts] Stream0 dt output for me… Christian Huitema
- Re: [quicwg/base-drafts] Stream0 dt output for me… ianswett
- Re: [quicwg/base-drafts] Stream0 dt output for me… ianswett
- Re: [quicwg/base-drafts] Stream0 dt output for me… Martin Thomson
- Re: [quicwg/base-drafts] Stream0 dt output for me… Martin Thomson
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… Martin Thomson
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… Rui Paulo
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… Rui Paulo
- Re: [quicwg/base-drafts] Stream0 dt output for me… Mike Bishop
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… Rui Paulo
- Re: [quicwg/base-drafts] Stream0 dt output for me… Rui Paulo
- Re: [quicwg/base-drafts] Stream0 dt output for me… Rui Paulo
- Re: [quicwg/base-drafts] Stream0 dt output for me… Rui Paulo
- Re: [quicwg/base-drafts] Stream0 dt output for me… Rui Paulo
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… Rui Paulo
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… Rui Paulo
- Re: [quicwg/base-drafts] Stream0 dt output for me… Rui Paulo
- Re: [quicwg/base-drafts] Stream0 dt output for me… ianswett
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… ianswett
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… Mike Bishop
- Re: [quicwg/base-drafts] Stream0 dt output for me… Mike Bishop
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… Martin Thomson
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… Martin Thomson
- Re: [quicwg/base-drafts] Stream0 dt output for me… Martin Thomson
- Re: [quicwg/base-drafts] Stream0 dt output for me… ianswett
- Re: [quicwg/base-drafts] Stream0 dt output for me… Martin Thomson
- Re: [quicwg/base-drafts] Stream0 dt output for me… Martin Thomson
- Re: [quicwg/base-drafts] Stream0 dt output for me… Kazuho Oku
- Re: [quicwg/base-drafts] Stream0 dt output for me… Kazuho Oku
- Re: [quicwg/base-drafts] Stream0 dt output for me… Mike Bishop
- Re: [quicwg/base-drafts] Stream0 dt output for me… Mike Bishop
- Re: [quicwg/base-drafts] Stream0 dt output for me… Nick Banks
- Re: [quicwg/base-drafts] Stream0 dt output for me… Nick Banks
- Re: [quicwg/base-drafts] Stream0 dt output for me… ekr
- Re: [quicwg/base-drafts] Stream0 dt output for me… Christopher Wood
- [quicwg/base-drafts] Stream0 dt output for merge … ekr