Re: [quicwg/base-drafts] Servers SHOULD NOT misuse the CANCELLED state (#770)

Mike Bishop <notifications@github.com> Mon, 11 September 2017 21:48 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F0A41320CF for <quic-issues@ietfa.amsl.com>; Mon, 11 Sep 2017 14:48:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.615
X-Spam-Level:
X-Spam-Status: No, score=-0.615 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id feC2dwJbViyR for <quic-issues@ietfa.amsl.com>; Mon, 11 Sep 2017 14:48:06 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D6FD8132331 for <quic-issues@ietf.org>; Mon, 11 Sep 2017 14:48:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=UdaNjChockcUbdcXp7hCio+cP2E=; b=j7rDa3/+GGGJecan wdx3BlOK4dXmAfhDg/apYU7Sj4fuf8WU106okucRVKd/5FwWA/ByA5v4wQgom8mW f8ElW8Js7VCBj6URDsE/Qxhk65tgvk24GmJy1sLo/tjb5h0jUuWPTj3YLc4FkMSm OR2yrfut8hl8o8z9dsDYty1/Mbk=
Received: by filter1091p1mdw1.sendgrid.net with SMTP id filter1091p1mdw1-11787-59B70491-47 2017-09-11 21:48:01.517957728 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id NBzq3JpXTTaCWe4DyyynHg for <quic-issues@ietf.org>; Mon, 11 Sep 2017 21:48:01.482 +0000 (UTC)
Date: Mon, 11 Sep 2017 21:48:01 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1deab3982c7783055f17e22e607c605c18e9cf6f92cf0000000115cec69092a169ce0f4eabc3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/770/review/61966390@github.com>
In-Reply-To: <quicwg/base-drafts/pull/770@github.com>
References: <quicwg/base-drafts/pull/770@github.com>
Subject: Re: [quicwg/base-drafts] Servers SHOULD NOT misuse the CANCELLED state (#770)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59b70490597cb_1000e3faa72a51c3c97954"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3OBLLymRXwufjQ5ICG6csRLtWc+juVoZbrEA VoJYC+DJa8i4/2M+LZm3j2zEWLWyV8mbHMvATbJ/PZJ+ikaro6d/XfW9kQiQxCiEtqcPaaHkOssvAc GmEjH1BPLxItf+oHCcL8msWh5oXs6aIZVLMv6PKhz5vqihMoU7WTD54NOI6jBg3diY0h3yy2JLRQAc Q=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/w1tP3HxmUkEdS1JF6DVKi7TEqTI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Sep 2017 21:48:07 -0000

MikeBishop commented on this pull request.



> @@ -767,14 +767,20 @@ indicated in the GOAWAY frame, those requests were not and will not be
 processed.  Endpoints SHOULD reset any streams above this ID with the error code
 HTTP_REQUEST_CANCELLED.  Servers MAY also reset streams below the indicated ID
 with HTTP_REQUEST_CANCELLED if the associated requests were not processed.
+Servers MUST NOT use the HTTP_REQUEST_CANCELLED status for requests which were
+partially or fully processed.

Following paragraph discusses what clients do with cancelled requests and this PR adds, "However, if a stream is cancelled after receiving a partial response, the response SHOULD NOT be used and the request cannot be safely retried."

Though rereading it, it might be clearer to swap the order of the last two sentences.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/770#discussion_r138200961