Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)

Benjamin Saunders <notifications@github.com> Wed, 12 December 2018 01:58 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B3FE612E043 for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 17:58:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ulkJlQm5hrwR for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 17:58:05 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4EBA4124D68 for <quic-issues@ietf.org>; Tue, 11 Dec 2018 17:58:05 -0800 (PST)
Date: Tue, 11 Dec 2018 17:58:04 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544579884; bh=F/xQy5HQUB5zQpliCZGhc6szxH1PMPt/f7RiSDs4+1I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=EBGu4ZnKZp3164xSIqD8yJhT4tfXHsj6P2zevUZoPKGOuAYPFf5E7KB8YE/KHtpnh TFxVFnHuwEnBRxqV2soJZwniY3TCFMG2lHPT0iPAM0lRq5Bo8DUhAhF8evrcu2PMO4 RB/Z9NiT/xyygB8S4Khk0wBmlbNWO4an52O3xK2A=
From: Benjamin Saunders <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9e3f49f56435fb0f7d5db4655e53aa87a1a260c092cf0000000118282d2c92a169ce173be661@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2113/c446432740@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2113@github.com>
References: <quicwg/base-drafts/pull/2113@github.com>
Subject: Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c106b2c41160_29073fa3996d45bc1868e3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: Ralith
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/w31KOKTbD2QqWGUTEIgjoEdaVK0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Dec 2018 01:58:07 -0000

I think the verification procedure defined here still spuriously fails when the receiver sends a pair of ACK such that each ACK newly acknowledges at least one packet not acknowledged by the other (for example, due to an implementation aggressively limiting the number of ACK blocks sent), and the ACKs are reordered such when the sender receives them, it sees the one with higher ECN counters first. By my reading, the apparent reduction in ECN would cause verification to fail.

Ignoring ECN blocks from ACKs whose largest acked PN is not higher than that of every previous ACK would resolve this problem by ensuring that reordered ECN blocks are always ignored, and subsumes the "no new acknowledgements" test.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2113#issuecomment-446432740