IETF Logo Mail Archive

Re: [quicwg/base-drafts] Persistent congestion pseudocode to match text (#4010)

ianswett <notifications@github.com> Mon, 31 August 2020 21:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 60D593A1984 for <quic-issues@ietfa.amsl.com>; Mon, 31 Aug 2020 14:48:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.009
X-Spam-Level:
X-Spam-Status: No, score=-2.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bPs0SfZYECus for <quic-issues@ietfa.amsl.com>; Mon, 31 Aug 2020 14:48:48 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3B26D3A1982 for <quic-issues@ietf.org>; Mon, 31 Aug 2020 14:48:48 -0700 (PDT)
Received: from github-lowworker-6b40fdd.va3-iad.github.net (github-lowworker-6b40fdd.va3-iad.github.net [10.48.16.64]) by smtp.github.com (Postfix) with ESMTP id 3DEDF600E0C for <quic-issues@ietf.org>; Mon, 31 Aug 2020 14:48:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598910527; bh=iMYQAtmPG7M2HZXqyL3qKuYIVDEMipVlgTE7lagFRFo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LajKfmRfkvnyo5mfafqRvL7FWcSxVKUdkPzyRxFUeRnxJonQznHTh9XDa5HLNvYwS Y1JLL4p7qo1IUdOgNKJsyzUBk3c5ZG789Wtu4LmYtvc0nwIAgBYyrhlVoaitBLzfhH 33ew51BCwWwszt2p7sW6gopc4K/ArmuaE+ILcvz8=
Date: Mon, 31 Aug 2020 14:48:47 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYHJNSZTB7RXP3VCUV5LFIT7EVBNHHCREMQGU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4010/review/478978660@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4010@github.com>
References: <quicwg/base-drafts/pull/4010@github.com>
Subject: Re: [quicwg/base-drafts] Persistent congestion pseudocode to match text (#4010)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f4d703f2ea5f_78f319647125f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/w6kF97HaWUxaMisFCOp9HDIXZEk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Aug 2020 21:48:49 -0000

@ianswett requested changes on this pull request.

This is likely good, but I'm worried this is becoming overly complex and implementation dependent.

I'd actually suggest we remove pseudocode for InPersistentCongestion() and leave it up to implementers.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4010#pullrequestreview-478978660

v2.23.0 | Report a Bug | By Email