IETF Logo Mail Archive

Re: [quicwg/base-drafts] Packet number echo with variable-length numbering (#391)

janaiyengar <notifications@github.com> Mon, 13 March 2017 19:37 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 230091294B9 for <quic-issues@ietfa.amsl.com>; Mon, 13 Mar 2017 12:37:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.616
X-Spam-Level:
X-Spam-Status: No, score=-0.616 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MwU-OLNXUfcs for <quic-issues@ietfa.amsl.com>; Mon, 13 Mar 2017 12:37:43 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D93D4129406 for <quic-issues@ietf.org>; Mon, 13 Mar 2017 12:37:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=VPANfcPRgH9LJ2s53fb0ZpFNmXU=; b=gxvXxZBebrJIxS+d qPADl/LIEdiPbeYDq1Hh6kBlas5ojZEzL8uOL5wE4rVFu8mXcNCj7RZJUEFIXMeb Y5gTD5c9mLXwViSjdpMvxEZhVm1V7gLl+8DdxGigSoD9p8+74Mvk20di8S3veo23 D1Gc3DyZYjUpE1ajm1amRgdgM1c=
Received: by filter0979p1mdw1.sendgrid.net with SMTP id filter0979p1mdw1-10211-58C6F505-37 2017-03-13 19:37:41.944249501 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id zjG1q3JZTrie54moQ1oIvw for <quic-issues@ietf.org>; Mon, 13 Mar 2017 19:37:41.840 +0000 (UTC)
Date: Mon, 13 Mar 2017 12:37:41 -0700
From: janaiyengar <notifications@github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/391/c286219405@github.com>
In-Reply-To: <quicwg/base-drafts/pull/391@github.com>
References: <quicwg/base-drafts/pull/391@github.com>
Subject: Re: [quicwg/base-drafts] Packet number echo with variable-length numbering (#391)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_58c6f505b666e_26fa3fb1cd549c3c3322c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0x0gTxj2vEyjkq4OKPtHV1+A3+Rhq9FV+SJO JGBY91tvFVyw3SsVIyAKD3qZETtSOvdL3SkScVU2Ch4ZnCx3TKNhQjXRjHc/V38jvHjg4bvFpCqmpI Zoqu3FdR1Bn69aOaZB5pbCWnk1gXNUxNoIupvpIGyFpWI+ap7osfC1Pg2ja7YuG/J32gKR4SQPpXFs 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wGH5MBwqonHeCuU-AjhbXBN3tgM>
Cc: Subscribed <subscribed@noreply.github.com>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.17
Reply-To: quic@ietf.org
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Mar 2017 19:37:44 -0000

Thanks for writing this up. We can worry about the details later, but this question of exposing largest acked needs discussion. A couple of comments in the meanwhile:
(i) I'd much prefer the variable-length version to the fixed-length one, FWIW.
(ii) if we decide to go this route, I would push towards requiring this packet header when the ACK frame is present and removing the largest acked out of the ACK frame entirely.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/391#issuecomment-286219405

v2.35.0 | Report a Bug | By Email | System Status