IETF Logo Mail Archive

Re: [quicwg/base-drafts] Extension frames (#1068)

Martin Thomson <notifications@github.com> Fri, 06 April 2018 00:05 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD4F712E04B for <quic-issues@ietfa.amsl.com>; Thu, 5 Apr 2018 17:05:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.391
X-Spam-Level:
X-Spam-Status: No, score=-0.391 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i-exSD1qMMQL for <quic-issues@ietfa.amsl.com>; Thu, 5 Apr 2018 17:05:46 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 75C2B12785F for <quic-issues@ietf.org>; Thu, 5 Apr 2018 17:05:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=qVEx8BYT+xPpeTZnCDABHGp2J64=; b=GIE01/miPfRuwIOF Yzd0koiuCQCwu61903iBp1CHo8Hp3oYAO0gNBmLaCiOZpzZzykpvzOZYbjlmG3a3 VP1elueWG5MtzbGeZ96r7yrVzb+wA5DpJp5Suig42oowG3JbSRKz6GR17jX8M+a0 D+qZM3/nMq7VxBd7S2nkyvuG51c=
Received: by filter0122p1las1.sendgrid.net with SMTP id filter0122p1las1-6778-5AC6B9A8-6 2018-04-06 00:04:56.250314735 +0000 UTC
Received: from smtp.github.com (out-1.smtp.github.com [192.30.252.192]) by ismtpd0040p1mdw1.sendgrid.net (SG) with ESMTP id LE0J8ldAS_KnvytLKqCqIg for <quic-issues@ietf.org>; Fri, 06 Apr 2018 00:04:55.861 +0000 (UTC)
Date: Fri, 06 Apr 2018 00:04:56 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8bf7be182ac6629251c8b75d87b8dcd7f46a846192cf0000000116de7ba792a169ce115ea54e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1068/review/109915033@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1068@github.com>
References: <quicwg/base-drafts/pull/1068@github.com>
Subject: Re: [quicwg/base-drafts] Extension frames (#1068)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ac6b9a7df349_50a33f84c2a7ef2816463f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak06+aUpfN8XOWCcplU+slF+Q4M9GR9EeX2Ps1 TxCOhrniM3cl3cOLpsgEZ7qSf2hS0cKkTBVrBs3rXzQqLskg9VSA83XkTBTQpqokDpvYZaKwzF4TUU /uqQW37M7zQhxYLZPWVHvMqi2kpK0rOVl4EkxLZzTvcO2VHzD9oD38/wjKChBtAi6xv5bhl8Wh0vFd s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wKXY2ODZxftXuxVyyBZoPM3EevQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2018 00:05:48 -0000

martinthomson commented on this pull request.



>        (65535)
    } TransportParameterId;
 
+   struct {
+      uint8 frame_type;
+      uint16 extension_frame_identifier;
+   } ExtensionFrameMappings<3..2^16-1>;

This is idiomatic in TLS.  Take a look at RFC 7301 and you will see the same repetition.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1068#discussion_r179632139

v2.31.3 | Report a Bug | By Email | System Status