Re: [quicwg/base-drafts] Immediately close with INVALID_TOKEN (#3107)

ianswett <notifications@github.com> Tue, 22 October 2019 04:29 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 92F94120058 for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:29:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.596
X-Spam-Level:
X-Spam-Status: No, score=-1.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id opu7PpieZYTV for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:29:26 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 348D1120074 for <quic-issues@ietf.org>; Mon, 21 Oct 2019 21:29:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=AeI8eU7tQXkl94pEj6oOdL5cu1U=; b=wz8+95beSA2z51zb 92w4U5mXMVsSQU+aEsPgsl276W3oHTNYMqnL+gLH12KSN+Tk7a9dgu6zvjVcthrI StUGxQiYcEuQxEF6c40611JHztIrl4Yz0NrOenAUJFUk01EHGoiYFtO/cQ4DtNX3 tOfIDZxXMsF4SicVmECpZOwFd7Q=
Received: by filter0916p1las1.sendgrid.net with SMTP id filter0916p1las1-12784-5DAE7612-E 2019-10-22 03:22:58.630562957 +0000 UTC m=+361622.682322585
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) by ismtpd0031p1mdw1.sendgrid.net (SG) with ESMTP id eSLAGFjYSnOPhhGod_NdYg for <quic-issues@ietf.org>; Tue, 22 Oct 2019 03:22:58.477 +0000 (UTC)
Date: Tue, 22 Oct 2019 03:22:58 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2QXSGFUGJR3QHE5SF3XO3JZEVBNHHB4ST4NM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3107/review/304949001@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3107@github.com>
References: <quicwg/base-drafts/pull/3107@github.com>
Subject: Re: [quicwg/base-drafts] Immediately close with INVALID_TOKEN (#3107)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dae760cd1c87_743a3fefbbacd95c592d3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0N9jQhh/Xo+FV4zZsECsXsh5ULIx66vezwvG YqWdGGB8/xL6SQ8RD55SBH3XHZWZyQK3hB0d/Al0AVNvKH+jVfawrP9PESXHAOdQGCBkpydPLFzWVA +k3iDFIFGOHuCz3mmZTIOtpI9nHrg5DBSZCUA8vdGIP8dJQ2GZmqvsmKvw==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wKdZB9-ZPkf-p2wEnd4K3C4jhCg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 04:29:29 -0000

ianswett commented on this pull request.



> @@ -1641,6 +1641,14 @@ of connection establishment.  By giving the client a different connection ID to
 use, a server can cause the connection to be routed to a server instance with
 more resources available for new connections.
 
+If a server receives a client Initial with a unverifiable Retry token,
+it knows the client will not accept another Retry token.  It can either
+proceed with the handshake without verifying the token or immediately close
+({{immediate-close}}) the connection with an connection error of
+INVALID_TOKEN to cause the handshake to fail quickly instead of waiting
+for the client to timeout.  When a client receives a CONNECTION_CLOSE
+with an error of INVALID_TOKEN, it MAY create a new connection.

SG, sentence removed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3107#discussion_r337318836