[quicwg/base-drafts] Writing after closed frame enqueued (#777)
ekr <notifications@github.com> Mon, 18 September 2017 19:28 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0EA34133047 for <quic-issues@ietfa.amsl.com>; Mon, 18 Sep 2017 12:28:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.616
X-Spam-Level:
X-Spam-Status: No, score=-5.616 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hZ2MS1akI5O3 for <quic-issues@ietfa.amsl.com>; Mon, 18 Sep 2017 12:28:28 -0700 (PDT)
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2-ext6.iad.github.net [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 985161320D8 for <quic-issues@ietf.org>; Mon, 18 Sep 2017 12:28:28 -0700 (PDT)
Date: Mon, 18 Sep 2017 12:28:27 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1505762907; bh=ZRMbXnpHOCu5YkogMGQq8RwV0cWjCdXmT2Bi/dhTRmM=; h=From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=wvWNnkU9bzTA9l+d6cVyiKTdqzckgak2jzSft2Wa8ILbkroJw+mtjI8cx+sdFn838 /B9If3qQrOv7uc+4KVtGE+TvoQJ/lNnsdwOh43KdbIXHNW9ku5sHmI2qdknH93pulG prCaeuZV60Sp5ifV9lk8y6v+fhOYBR1pvDpE21og=
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab826968d5cdc954b4033302ff16c508ca7a76788f92cf0000000115d7e05b92a169ce0f69d2d9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/777@github.com>
Subject: [quicwg/base-drafts] Writing after closed frame enqueued (#777)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59c01e5bca998_1d83f3fd6a41c4f3471768"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wLFfZ9HhRZsgAK_4hTtYrUfUmTI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2017 19:28:30 -0000
I'm not sure if this belongs in the QUIC spec, but I had to handle it specially in Minq so I thought I would mention it. The current text shows the transition from OPEN to HALF_CLOSED (LOCAL) happening when you send a FIN. However, if you think of this from an API perspective, that's not quite what you want. Consider the case where you have a stream flow control window of 1000. You write 999 and then 1000-1999, and then call stream.Close(). At this point, you have in queue: ``` [0-999] (sent, maybe un-acked) [1000-1999] (not-sent) [2000: FIN] (not sent) ``` You're still in OPEN because you haven't sent the FIN, but the implementation should stop you from doing another Write() at this point. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/777
- [quicwg/base-drafts] Writing after closed frame e… ekr
- Re: [quicwg/base-drafts] Writing after closed fra… Martin Thomson
- Re: [quicwg/base-drafts] Writing after closed fra… Martin Thomson
- Re: [quicwg/base-drafts] Writing after closed fra… Martin Thomson