Re: [quicwg/base-drafts] Exception for Retire Prior To (#3643)

Jana Iyengar <notifications@github.com> Thu, 14 May 2020 03:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 647363A0935 for <quic-issues@ietfa.amsl.com>; Wed, 13 May 2020 20:17:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.269
X-Spam-Level:
X-Spam-Status: No, score=-3.269 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.173, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3rcu4nhLy82g for <quic-issues@ietfa.amsl.com>; Wed, 13 May 2020 20:17:55 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 703433A094B for <quic-issues@ietf.org>; Wed, 13 May 2020 20:17:55 -0700 (PDT)
Received: from github-lowworker-28f8021.ac4-iad.github.net (github-lowworker-28f8021.ac4-iad.github.net [10.52.25.98]) by smtp.github.com (Postfix) with ESMTP id 70067E0064 for <quic-issues@ietf.org>; Wed, 13 May 2020 20:17:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589426274; bh=Hp/xfzOmoRVGDSBJRiac/MQSoDQBfCLVTh8dw7kN0tQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=qAza75U/vr3RVOeasxhdKiN5n3y06oSOCw+xabmrXg53ZLGnc5/SIz23Wt7ddcMZ8 3504Uvmr5W3e1ecw5z/sy4S96Yr4bcFiF7iGA1wYpbqDvhQSyi4FXijp4vpC1euTM6 WbEvWszG9lCxV0DJUl0Vv40CSBvamMXSTIqykVZI=
Date: Wed, 13 May 2020 20:17:54 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2VZQEXCN5PDXZIS5N4ZCMWFEVBNHHCJO45K4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3643/review/411436933@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3643@github.com>
References: <quicwg/base-drafts/pull/3643@github.com>
Subject: Re: [quicwg/base-drafts] Exception for Retire Prior To (#3643)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ebcb86260583_61c13fb9c34cd96811234a"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wPxV8hzdAYj_5v4_z3m7B7kcHWQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 May 2020 03:17:58 -0000

@janaiyengar commented on this pull request.



> @@ -1050,8 +1050,14 @@ An endpoint SHOULD ensure that its peer has a sufficient number of available and
 unused connection IDs.  Endpoints store received connection IDs for future use
 and advertise the number of connection IDs they are willing to store with the
 active_connection_id_limit transport parameter.  An endpoint MUST NOT provide
-more connection IDs than the peer's limit.  An endpoint that receives more
-connection IDs than its advertised active_connection_id_limit MUST close the
+more connection IDs than the peer's limit, with the exception that connection

Both these sentences are onerous to read and super long... can you break them up a bit?

> +will stay within the limit.  An endpoint that receives a NEW_CONNECTION_ID
+frame that increases the number of active connection IDs - without a Retire
+Prior To field that requests retirement of enough active connections to keep the
+total number of active connection IDs within the value the endpoint advertised
+in its active_connection_id_limit transport parameter - MUST close the
 connection with an error of type CONNECTION_ID_LIMIT_ERROR.

I can't comment on this change, so writing my comments here. The first sentence needs editorial fixing ("might cause an endpoint might add some active"). But I definitely prefer this version to the original.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3643#pullrequestreview-411436933