[quicwg/base-drafts] Choose between semicolons and parenthesis (#3591)

Eric Kinnear <notifications@github.com> Tue, 21 April 2020 05:09 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 79E293A094D for <quic-issues@ietfa.amsl.com>; Mon, 20 Apr 2020 22:09:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.199
X-Spam-Level:
X-Spam-Status: No, score=-1.199 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZdxpQy2PPVkL for <quic-issues@ietfa.amsl.com>; Mon, 20 Apr 2020 22:08:58 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 96CDE3A0949 for <quic-issues@ietf.org>; Mon, 20 Apr 2020 22:08:58 -0700 (PDT)
Received: from github-lowworker-2ef7ba1.ac4-iad.github.net (github-lowworker-2ef7ba1.ac4-iad.github.net [10.52.16.66]) by smtp.github.com (Postfix) with ESMTP id B74A18C08AE for <quic-issues@ietf.org>; Mon, 20 Apr 2020 22:08:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1587445737; bh=UcCtbOrDKL/xkab6ZlMBinRNMnYfrOvLSiFkHxvTpbU=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=bq0aLXzMy3FWnPvgJskgVxOSmzq3Xv0SVUGW4rskJFMHppPZLTIyvqwr7k55Sb/AO 6B7XN+2+yBIwkgBIlzAavyQK0kra3BWWRpykog52/Tj1oNzvsf2y6x1F8GRIXtERT0 jV2Fap5O7q17RXS4n6j8KlPXhjD0I1hCegpW2g8U=
Date: Mon, 20 Apr 2020 22:08:57 -0700
From: Eric Kinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7QPLBCBW4PSG6ZLD54VJQOTEVBNHHCH67A2Y@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3591@github.com>
Subject: [quicwg/base-drafts] Choose between semicolons and parenthesis (#3591)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e9e7fe9a6d5a_312d3fc6d1ecd95c436526"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wUCrYbVr-aLlqaZK6-bgK-TA5hA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Apr 2020 05:09:02 -0000

This is beyond editorial, so skipping an issue for this, but since it came up in #3589.

Bikeshed time! Let&#39;s pick between semicolons and parenthesis. 

This PR unifies the &quot;see Section X.Y.Z&quot; at the ends of sentences into the form 
```
sentence words; see Section X.Y.Z.
```
instead of 
```
sentence words (see Section X.Y.Z).
```

However, this doesn&#39;t touch the middle of sentences: 
```
These are some sentence words (see Section X.Y.Z) about some stuff you should probably do.
```
Suggestions welcome for the semicolon form of that. 

There are other cases that don&#39;t quite seem to fit with semicolons, as well: 
```
- write data, understanding when stream flow control credit
  ({{data-flow-control}}) has successfully been reserved to send the written
  data;
- end the stream (clean termination), resulting in a STREAM frame
  ({{frame-stream}}) with the FIN bit set; and
- reset the stream (abrupt termination), resulting in a RESET_STREAM frame
  ({{frame-reset-stream}}), if the stream was not already in a terminal state.
```
and this seems like it wouldn&#39;t want to split between two different styles:
```
This section describes streams in terms of their send or receive components.
Two state machines are described: one for the streams on which an endpoint
transmits data ({{stream-send-states}}), and another for streams on which an
endpoint receives data ({{stream-recv-states}}).
```
One last example for this one:
```
A receiver sets initial credits for all streams by sending transport parameters
during the handshake ({{transport-parameters}}).  A receiver sends
MAX_STREAM_DATA ({{frame-max-stream-data}}) or MAX_DATA ({{frame-max-data}})
frames to the sender to advertise additional credit.
```

And, finally, direct references without &quot;see&quot; too:
```
as a connection error of type STREAM_LIMIT_ERROR (Section X.Y.Z).
```
vs. 
```
as a connection error of type STREAM_LIMIT_ERROR; Section X.Y.Z.
```

So, for now, I&#39;ve changed all of the &quot;see Section X.Y.Z&quot; form to use semicolons, as they were pretty split between the two already.

Either way we choose, happy to switch this up to match (it&#39;s not consistent either way, so no matter what a change is necessary), so this PR can be used to go in either direction.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/3591

-- Commit Summary --

  * Unify on semicolon

-- File Changes --

    M draft-ietf-quic-transport.md (158)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/3591.patch
https://github.com/quicwg/base-drafts/pull/3591.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3591