Re: [quicwg/base-drafts] Fixed length CID or encode length somehow (#1640)
MikkelFJ <notifications@github.com> Wed, 08 August 2018 08:00 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 89724130DD1 for <quic-issues@ietfa.amsl.com>; Wed, 8 Aug 2018 01:00:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SAUvNW7t3eQq for <quic-issues@ietfa.amsl.com>; Wed, 8 Aug 2018 01:00:56 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C39D5126CB6 for <quic-issues@ietf.org>; Wed, 8 Aug 2018 01:00:55 -0700 (PDT)
Date: Wed, 08 Aug 2018 01:00:54 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533715254; bh=anVk+BIuaQuN9ze51t5aoicj6YBrVbB2xA1USeE4NvE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ndcOSrw202YnHBqAF9d9438yVEsXAjDsNxn70OgksSpp4Y32H3pwxgCxRNLODBnTJ kVYqGblRm9/1Vamu0yApKCTBAoHgwy9YpPjCeCUF0ZhVpwNAz53f97WMb2sz4sPqch zynfoLjQ2kL+S8TksQtkM5+N53y+Z0BtUJdFiZNM=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab010a63413405fcf6cc3545ec699aacc735a0403f92cf000000011782653692a169ce14c65c46@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1640/review/144306604@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1640@github.com>
References: <quicwg/base-drafts/pull/1640@github.com>
Subject: Re: [quicwg/base-drafts] Fixed length CID or encode length somehow (#1640)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b6aa336d39b2_22733fd88e6d45c4456774"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wW9hOpL_CfNtsW5RbSuTL6Kc8Mc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Aug 2018 08:00:58 -0000
mikkelfj commented on this pull request. > @@ -2679,7 +2679,9 @@ endpoint receives. This design relies on the peer always sending a connection ID in its packets so that the endpoint can use the connection ID from a packet to reset the connection. An endpoint that uses this design cannot allow its peers to send -packets with a zero-length destination connection ID. +packets with a zero-length destination connection ID and need to either use a +the same connection ID length for all connections or ensure that the connection +ID encodes its own length in a common fixed portion. It is not necessary to have a fixed portion. You can use bit 7 of each octet to indicate if there is more. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1640#pullrequestreview-144306604
- [quicwg/base-drafts] Fixed length CID or encode l… Martin Thomson
- Re: [quicwg/base-drafts] Fixed length CID or enco… MikkelFJ
- Re: [quicwg/base-drafts] Fixed length CID or enco… Mike Bishop
- Re: [quicwg/base-drafts] Fixed length CID or enco… ianswett
- Re: [quicwg/base-drafts] Fixed length CID or enco… ianswett
- Re: [quicwg/base-drafts] Fixed length CID or enco… Mike Bishop
- Re: [quicwg/base-drafts] Fixed length CID or enco… Martin Thomson
- Re: [quicwg/base-drafts] Fixed length CID or enco… ianswett
- Re: [quicwg/base-drafts] Fixed length CID or enco… Mike Bishop
- Re: [quicwg/base-drafts] Fixed length CID or enco… Martin Thomson
- Re: [quicwg/base-drafts] Fixed length CID or enco… ekr
- Re: [quicwg/base-drafts] Fixed length CID or enco… Martin Thomson