Re: [quicwg/base-drafts] Octets that are sent twice (#1353)
Martin Thomson <notifications@github.com> Mon, 14 May 2018 06:34 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 570D212D77A for <quic-issues@ietfa.amsl.com>; Sun, 13 May 2018 23:34:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rNRvTEmDFNPG for <quic-issues@ietfa.amsl.com>; Sun, 13 May 2018 23:34:04 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CF62D127876 for <quic-issues@ietf.org>; Sun, 13 May 2018 23:34:03 -0700 (PDT)
Date: Sun, 13 May 2018 23:34:03 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1526279643; bh=zvpplHIP3jrutQg5lj8oFM364AJWg97UejtJKNmRKyI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eZtwbWAyI+iDEk3Asvj85EDHy3aYc/b7dN0GbskkKjOjDvtAnD9E9X0oxIBb9DZfY NFN+w4PSuY9e/aDp7eTe9IYW3gUU3onQJFNIv6RkuZTJdZDEocHs4e83M1NTOCLaqP wB3gH9ZfGBM8vuRT35rp1DOEWszgPqo9rmda13To=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf8654d22b0d15c370ec88f184caaf33140a90e6292cf000000011710efdb92a169ce133b2693@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1353/review/119706586@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1353@github.com>
References: <quicwg/base-drafts/pull/1353@github.com>
Subject: Re: [quicwg/base-drafts] Octets that are sent twice (#1353)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5af92ddb3e490_7adc2b025db5ef5c20964e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wYYFQxO7E-dxSzOoxTO77MCYVyQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 May 2018 06:34:05 -0000
martinthomson commented on this pull request. > @@ -3612,10 +3612,15 @@ When new data is to be sent on a stream, a sender MUST set the encapsulating STREAM frame's offset field to the stream offset of the first byte of this new data. The first octet of data on a stream has an offset of 0. An endpoint is expected to send every stream octet. The largest offset delivered on a stream -MUST be less than 2^62. A receiver MUST ensure that received stream data is -delivered to the application as an ordered byte-stream. Data received out of -order MUST be buffered for later delivery, as long as it is not in violation of -the receiver's flow control limits. +MUST be less than 2^62. + +A receiver MUST ensure that received stream data is delivered to the application That text isn't changed. It's what we litigated (at some length), but moved into a new paragraph, because the old one was getting unwieldy. You are right, though. It seems to imply that it has to deliver in order, when the intent was that it be capable of doing so. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1353#discussion_r187846970
- [quicwg/base-drafts] Octets that are sent twice (… Martin Thomson
- Re: [quicwg/base-drafts] Octets that are sent twi… ianswett
- Re: [quicwg/base-drafts] Octets that are sent twi… Martin Thomson
- Re: [quicwg/base-drafts] Octets that are sent twi… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Octets that are sent twi… Mike Bishop
- Re: [quicwg/base-drafts] Octets that are sent twi… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Octets that are sent twi… Mike Bishop
- Re: [quicwg/base-drafts] Octets that are sent twi… MikkelFJ
- Re: [quicwg/base-drafts] Octets that are sent twi… Martin Thomson
- Re: [quicwg/base-drafts] Octets that are sent twi… Martin Thomson
- Re: [quicwg/base-drafts] Octets that are sent twi… Martin Thomson
- Re: [quicwg/base-drafts] Octets that are sent twi… ianswett
- Re: [quicwg/base-drafts] Octets that are sent twi… ianswett
- Re: [quicwg/base-drafts] Octets that are sent twi… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Octets that are sent twi… Martin Thomson
- Re: [quicwg/base-drafts] Octets that are sent twi… Martin Thomson
- Re: [quicwg/base-drafts] Octets that are sent twi… ianswett
- Re: [quicwg/base-drafts] Octets that are sent twi… Martin Thomson
- Re: [quicwg/base-drafts] Octets that are sent twi… janaiyengar
- Re: [quicwg/base-drafts] Octets that are sent twi… janaiyengar