IETF Logo Mail Archive

Re: [quicwg/base-drafts] PADDING counts towards byte in flight (#1540)

MikkelFJ <notifications@github.com> Mon, 09 July 2018 13:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9F629130FCB for <quic-issues@ietfa.amsl.com>; Mon, 9 Jul 2018 06:38:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.109
X-Spam-Level:
X-Spam-Status: No, score=-1.109 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, GB_SUMOF=5, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 84oCeVEsdAkx for <quic-issues@ietfa.amsl.com>; Mon, 9 Jul 2018 06:38:56 -0700 (PDT)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 71653130FD0 for <quic-issues@ietf.org>; Mon, 9 Jul 2018 06:38:54 -0700 (PDT)
Date: Mon, 09 Jul 2018 06:38:54 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531143534; bh=oqLGgErxFm29dwowwHitUDFXyDgBPlQnvS3VJsFWywo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=InEUsYCDN03M0kBwzBI1szhJGUMwNpu3tdCoB/KhxlyvK3LfHjhTV9nz0fXq++1LQ 2Cmw7tx5uABdnU9+s4EtqckCwyTLs82crI/E5/ql0yrjcq0GxFqJzHBFJVRU7fA2Tc PJfjwbZZfP2GVPq8+4rztohOEcEqCSI5tklf5Eis=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8d8dab394a8dd6c20e54fbd4acb9b259125f7fd592cf00000001175b276e92a169ce143b9c8b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1540/review/135420006@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1540@github.com>
References: <quicwg/base-drafts/pull/1540@github.com>
Subject: Re: [quicwg/base-drafts] PADDING counts towards byte in flight (#1540)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b43656e119a9_43433fcc44476f80463a5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wYc-WBSXh0qUk953DU4lX1jiPZo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jul 2018 13:38:58 -0000

mikkelfj commented on this pull request.



> @@ -1018,7 +1025,7 @@ ecn_ce_counter:
 
 bytes_in_flight:
 : The sum of the size in bytes of all sent packets that contain at least
-  one retransmittable frame, and have not been acked or declared
+  one retransmittable or PADDING frame, and have not been acked or declared
   lost. The size does not include IP or UDP overhead.

But presumably it does include AEAD tags?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1540#pullrequestreview-135420006

v2.28.0 | Report a Bug | By Email | System Status