Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)

Magnus Westerlund <notifications@github.com> Tue, 19 June 2018 12:23 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2027C130E88 for <quic-issues@ietfa.amsl.com>; Tue, 19 Jun 2018 05:23:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KLlSLG3qgE_g for <quic-issues@ietfa.amsl.com>; Tue, 19 Jun 2018 05:23:52 -0700 (PDT)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 992F8130E23 for <quic-issues@ietf.org>; Tue, 19 Jun 2018 05:23:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=6xnKp9olEEcNv0abhjew2pBUAmw=; b=NQk3cmsV81l2G3Ix 1IsKvD86ki8MuX5m7k7wWsWTZjxYTPleoEiqYq7HTDpfhqqTjOSK9tzlGcFq2g9I gh/Z8LYTkVs9ub6QSkvuOPcFXzt/VvCh5yJPOq8U+vYPzyQ4bW7zoIb5lWS+rQB8 EGCp9drS8RJ7vhpb3caoW1zIQIg=
Received: by filter0045p1iad2.sendgrid.net with SMTP id filter0045p1iad2-31139-5B28F5D7-D 2018-06-19 12:23:51.35197951 +0000 UTC
Received: from github-lowworker14-cp1-prd.iad.github.net (unknown [192.30.252.38]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id ljcdVhPRTLuRJAW0tlVj0g for <quic-issues@ietf.org>; Tue, 19 Jun 2018 12:23:51.267 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker14-cp1-prd.iad.github.net (Postfix) with ESMTP id 3FCF8E0610 for <quic-issues@ietf.org>; Tue, 19 Jun 2018 05:23:51 -0700 (PDT)
Date: Tue, 19 Jun 2018 12:23:51 +0000
From: Magnus Westerlund <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe76d66519d63217489572c6705c5ccc4ffa9118892cf000000011740b7d792a169ce13656182@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1372/review/129943285@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1372@github.com>
References: <quicwg/base-drafts/pull/1372@github.com>
Subject: Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b28f5d73e23b_6db53fa0dbf7af8843848"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gloinul
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0CxNNHaLlRDDlmA78RZ/877VMhI3CtpnK1nw sLl3sOpe3pSFldAmxwR6LRxdOHCGacdJdS0vgImNOuWFMXOooVLcfVpPypJuzajPGphq1OYBPDC+XY q4a6Ea0NSr9KJXvMeo+RbS2+s4Df9G1Pzzm6cBJ8/sRSI95UnjDfpTspMS+T0dCp2uKprXbKU/zzw6 k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wlLhr6R1O77e6RQuYu0oRyecf9A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2018 12:23:58 -0000

gloinul commented on this pull request.



> +This capability check thus has verified that one direction of the path between
+the peers is free from issues with ECN bleaching and that the application does
+not experience problems with access to the ECN field in the IP header. In this
+case the marking of the generated packets with ECT continues.
+
+If an ACK frame (not the ACK_ECN frame) is used to acknowledge reception of
+packets that was marked as ECT in the sender, or if the comparision of the
+counters with the total of acknolwedged packets indicates that not all packets
+arrive as ECT(0), ECT(1) or ECN-CE, then the path is determined as not ECN
+Capable.  If the endpoint determine the path as currently not ECN capable it
+SHALL stop marking the packets as ECT, and instead mark them as Not-ECT. If the
+connection is migrated then the ECN capability check is rerun as specified in
+{{ecn-connection-migration}}.
+
+
+### Continuous Verification of ECN {#ecn-continuous-verification}

It also requires one to send one ACK_ECN frame for any marked, and one ACK for any Not-ECT marked IP packets. That was not my original intention, but I think works fine. So, yes I think changing the ACK_ECN frame to use this proposal would improve efficiency when it works. 

When it comes to ACK loss there will be no effect if the lost ACKs only acknowledged ECT(0) pakets. If there was ACKs lost that incremented the CE or ECT(1) counters then it would be in the same situation. The sender can detect the event and record a new comparison point so that it doesn't effect the future bleaching detections. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1372#discussion_r196400399