IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make RST_STREAM a bit on STREAM frame (#775)

Ryan Hamilton <notifications@github.com> Mon, 18 September 2017 22:19 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3C38B133011 for <quic-issues@ietfa.amsl.com>; Mon, 18 Sep 2017 15:19:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.019
X-Spam-Level:
X-Spam-Status: No, score=-2.019 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KEPG4dppY5hb for <quic-issues@ietfa.amsl.com>; Mon, 18 Sep 2017 15:19:36 -0700 (PDT)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8BFB9132941 for <quic-issues@ietf.org>; Mon, 18 Sep 2017 15:19:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=GnkWLksgonoOJp9xBpm3P3napLU=; b=b2fvp5K72whjt+j5 sesGlO2bEEGHVG43yFRnszpAG0vBXGv8viNQur+zijgCHsMGNvwVStgGZhy3rW8R umVYWf28LdWMAmHB6ecOutBLIgGYvYImd/rt/VFBhZrvxORBc181sdnyl/cy7T3A 1RqUxF0kQAzH5q7Rx7FnD5BmU5U=
Received: by filter0487p1mdw1.sendgrid.net with SMTP id filter0487p1mdw1-7414-59C0466D-57 2017-09-18 22:19:25.727310596 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0050p1mdw1.sendgrid.net (SG) with ESMTP id HZUcyMpJSmi2VgL50tMspA for <quic-issues@ietf.org>; Mon, 18 Sep 2017 22:19:25.688 +0000 (UTC)
Date: Mon, 18 Sep 2017 22:19:26 +0000
From: Ryan Hamilton <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abdb4662d4e742a8166843e653e9c2b8a1ec5267c792cf0000000115d8086d92a169ce0f6980d1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/775/330372425@github.com>
In-Reply-To: <quicwg/base-drafts/issues/775@github.com>
References: <quicwg/base-drafts/issues/775@github.com>
Subject: Re: [quicwg/base-drafts] Make RST_STREAM a bit on STREAM frame (#775)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59c0466d6444c_6f153fe788982f38362ab"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: RyanAtGoogle
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1ByhSotYNR4a865wMQYfM/Y7TgNBWb/UZoE3 3CTmi6tg+O7Plt87r6gSBNapOsKe3QFlzx8eaTA2zRXYPaPh/0jGTuCbQpXNjabXlAbwrY9UryswW0 hE+SUWSIEPaxrBJNIZnM33xRp8i6gfEQCFAExQRcOPOdNhoNk1NNlBkH7t8VVahpDtSHVAEe4I4gdN 4=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wr0ZMfy9A6XqC7Hf6mDNrIhAm6I>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2017 22:19:38 -0000

When you receive a STREAM frame, don't you have to look up the stream in order to deliver the stream data? In other words, I'm surprised that it's any less work to handle receipt of a RST_STREAM frame than it is to handle receipt of a STREAM frame with a build-in RST_STREAM semantic. Would you like to have only one place in the code which does the stream id to stream lookup? (That place being receipt of a STREAM frame).

Keep in mind that depending on how you implement things, receipt of a WINDOW_UPDATE frame needs to frob the stream as does receipt of an ACK frame for a packet containing data sent by that stream.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/775#issuecomment-330372425

v2.46.0 | Report a Bug | By Email | System Status