Re: [quicwg/base-drafts] Packet-threshold loss detection poorly interacts with packet coalescing (#2653)

ianswett <notifications@github.com> Thu, 25 April 2019 12:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0A684120072 for <quic-issues@ietfa.amsl.com>; Thu, 25 Apr 2019 05:39:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dA_wVKgqXRhm for <quic-issues@ietfa.amsl.com>; Thu, 25 Apr 2019 05:39:31 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 55B4D120047 for <quic-issues@ietf.org>; Thu, 25 Apr 2019 05:39:31 -0700 (PDT)
Date: Thu, 25 Apr 2019 05:39:29 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1556195969; bh=ysYQKx0g8qHUabUEt8BgX/hEjuiDleLq6poWbatm/hQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mPSITha9Rs56emEh7PdhDS9EVLTUF+PYaybRJqkZxPeAoXfoECKWkj4jA22PJMwFp W17W+wA+cz0BFdmy4//EijX70pdGo7m/z7S26BF4eobQ2SYixFiI2ANgemfw9iHNlA bCzjvMqTvc4JrCuPGPVD6BC5hjW5MRt54cjuaHjw=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7VK3C33GL53HSVV552Z3OQDEVBNHHBUDEE3Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2653/486655306@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2653@github.com>
References: <quicwg/base-drafts/issues/2653@github.com>
Subject: Re: [quicwg/base-drafts] Packet-threshold loss detection poorly interacts with packet coalescing (#2653)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cc1aa81d6640_514e3f85ea0cd96021247a"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ws1WvUihTLJLgx38_g3k4OKmigc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Apr 2019 12:39:33 -0000

Can you be more specific about the issue you're seeing and how packet coalescing is relevant, because I don't understand the issue.

If you were allocating packet numbers from a single space when doing multiple PN spaces, then unless you adjust for that, you could become very sensitive to reordering, but that is implementation specific and doesn't involve coalescing.

We could disable packet threshold for Initial and Handshake PN spaces, and it likely wouldn't matter during the handshake since it's rare to have 3 packets outstanding at once anyway, so time threshold is likely to kick in sooner.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2653#issuecomment-486655306