Re: [quicwg/base-drafts] Allow servers to send a preferred address of each address family (#2296)

Kazuho Oku <notifications@github.com> Mon, 07 January 2019 00:15 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8F5C41310C4 for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 16:15:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pefmc9Bdg-Cy for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 16:15:56 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D78341310BE for <quic-issues@ietf.org>; Sun, 6 Jan 2019 16:15:55 -0800 (PST)
Date: Sun, 06 Jan 2019 16:15:55 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546820155; bh=1gvaUfH0TYNizMd8sMlocuF+pR/lIs+QvTC8ghCSxpk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=x0hLd4j8iQgI61Qp8ZS+JiKTke9j/PjL/7bXFxni2T6TYlzKeb3ywMB6N3lzsqmN6 PBxJphdMON6IgrRbeBTyeDeZSV30FAzA+PMdK+xr7vAQoc5QkUhNOysrELYg/kkOjG YxPZt4dQ0+nYxhRPIpTnAV3lXSRKi8vbQ81LsC7M=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7d4c9ce00319f6dd576e494222d382f84324e23e92cf00000001184a5c3b92a169ce179bec73@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2296/review/189652023@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2296@github.com>
References: <quicwg/base-drafts/pull/2296@github.com>
Subject: Re: [quicwg/base-drafts] Allow servers to send a preferred address of each address family (#2296)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c329a3bc144_6db53fa6dd8d45b4190534"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wtBlyQr8f2wihJOsp5y946UP2rY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2019 00:15:58 -0000

kazuho commented on this pull request.



>  
 ~~~
    struct {
-     enum { IPv4(4), IPv6(6), (15) } ipVersion;
-     opaque ipAddress<4..2^8-1>;
+     opaque ipv4Address<0..2^8-1>;

IIUC the text says that the value should be a zero-length byte array if the address type is not used, rather than using an invalid address.

Therefore I think the correct notation is:
```
opaque ipv4Address<0..4>;
opaque ipv6Address<0..16>;
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2296#discussion_r245529304