Re: [quicwg/base-drafts] Defense against version number corruption (#3532)

Martin Thomson <notifications@github.com> Wed, 18 March 2020 21:16 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EB6A63A1C68 for <quic-issues@ietfa.amsl.com>; Wed, 18 Mar 2020 14:16:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.017
X-Spam-Level:
X-Spam-Status: No, score=-3.017 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-1.463, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id avcvv9qhbekq for <quic-issues@ietfa.amsl.com>; Wed, 18 Mar 2020 14:16:53 -0700 (PDT)
Received: from xtrwsrhn.outbound-mail.sendgrid.net (xtrwsrhn.outbound-mail.sendgrid.net [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 215C13A0D8C for <quic-issues@ietf.org>; Wed, 18 Mar 2020 14:16:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=8jbg+drmWqP4AiRBrGXYZulIyUZOr+lU4oe74xSz8vQ=; b= eRmytyv7pJ7UXxh9PKtCrPESzTWQmqFywg0dMYeTa7IvcGBZmAVFRSHGcODnFXcD qrpTS4zy7GXvhog9H/7Gq0F60LVpH9f6H2EWuvPyxgzp6u9i25wIOWN30r8nsney 9mDFFhX/Bcaf+j+MII7cPJeVl8lBAlM6iRC1nhp3a+g=
Received: by filter1780p1mdw1.sendgrid.net with SMTP id filter1780p1mdw1-18914-5E728FC3-1D 2020-03-18 21:16:51.72552836 +0000 UTC m=+92612.993206702
Received: from github-lowworker-25680bd.va3-iad.github.net (unknown [140.82.115.5]) by ismtpd0115p1mdw1.sendgrid.net (SG) with ESMTP id g_Y0kPFFRe66xn9-5rDwgA for <quic-issues@ietf.org>; Wed, 18 Mar 2020 21:16:51.675 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-25680bd.va3-iad.github.net (Postfix) with ESMTP id 5FB2A140B18 for <quic-issues@ietf.org>; Wed, 18 Mar 2020 14:16:51 -0700 (PDT)
Date: Wed, 18 Mar 2020 21:16:51 +0000 (UTC)
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2XFBI4G2SSTFGJN3F4PZYMHEVBNHHCFTPLZM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3532/600862789@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3532@github.com>
References: <quicwg/base-drafts/issues/3532@github.com>
Subject: Re: [quicwg/base-drafts] Defense against version number corruption (#3532)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e728fc35e743_71f13ff2bb0cd9682927bc"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2vYaK4+uXCB3QcMXXyc5VnMMA/VrlwVuMAr9 N3boJcwZuDM44i440KvOjuWwvmbCF8OJghWg6g492x9f2vOHV1GsydB7Cifwwe6gLPOflGi73yWpVO ogN26v53WqJRsbdW+1DDawZRYoTCcoifMxpBpLLliS7l4gR9gwK16BsjWmUVkBFMKS0rIPE+teHw5y E=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wtQpGO0Rr6AInXN9BqgbvZtAT9I>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Mar 2020 21:16:55 -0000

We used to require that a client ignore Version Negotiation packets that include the version the client attempted.

@DavidSchinazi edited that out.  Maybe we should restore it.  That pushes the odds of failure to 1 in 90 quadrillion.  Would that help?

I want to say that this is a design issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3532#issuecomment-600862789