Re: [quicwg/base-drafts] Optional Idle Timeout (#1765)

[Martin Thomson <[e-mail]>]

martinthomson commented on this pull request.

I really like that we no longer have any mandatory transport parameters.

> @@ -1666,6 +1654,18 @@ ack_delay_exponent (0x0007):
   value is also used for ACK frames that are sent in Initial and Handshake
   packets.  Values above 20 are invalid.
 
+initial_max_uni_streams (0x0008):

Please don't move this.  The numbers are all out of order, but I do hope to fix that eventually.

> @@ -2531,9 +2531,9 @@ source address.
 
 ### Idle Timeout
 
-A connection that remains idle for longer than the advertised idle timeout (see
-{{transport-parameter-definitions}}) is closed.  A connection enters the
-draining state when the idle timeout expires.
+If the idle timeout is enabled, a connection that remains idle for longer than

This change isn't needed.  There is always an idle timeout, it's just that it is sometimes infinite.

>  
-: The initial maximum unidirectional streams parameter contains the initial
-  maximum number of unidirectional streams the peer may initiate, encoded as an
-  unsigned 16-bit integer.  If this parameter is absent or zero, unidirectional
-  streams cannot be created until a MAX_STREAM_ID frame is sent.  Setting this
-  parameter is equivalent to sending a MAX_STREAM_ID ({{frame-max-stream-id}})
-  immediately after completing the handshake containing the corresponding Stream
-  ID. For example, a value of 0x05 would be equivalent to receiving a
-  MAX_STREAM_ID containing 18 when received by a client or 19 when received by a
-  server.
+: The idle timeout is a value in seconds that is encoded as an unsigned 16-bit
+  integer.  There is no maximum value besides the maximum encodable value of
+  0xFFFF (about 18 hours).  If this parameter is absent or zero then the idle

I wouldn't bother with the maximum sentence thing.

>  
-: The initial maximum unidirectional streams parameter contains the initial
-  maximum number of unidirectional streams the peer may initiate, encoded as an
-  unsigned 16-bit integer.  If this parameter is absent or zero, unidirectional
-  streams cannot be created until a MAX_STREAM_ID frame is sent.  Setting this
-  parameter is equivalent to sending a MAX_STREAM_ID ({{frame-max-stream-id}})
-  immediately after completing the handshake containing the corresponding Stream
-  ID. For example, a value of 0x05 would be equivalent to receiving a
-  MAX_STREAM_ID containing 18 when received by a client or 19 when received by a
-  server.
+: The idle timeout is a value in seconds that is encoded as an unsigned 16-bit
+  integer.  There is no maximum value besides the maximum encodable value of
+  0xFFFF (about 18 hours).  If this parameter is absent or zero then the idle
+  timeout is disabled.  In this case, the transport never closes the connection
+  in response to being idle.

drop this last sentence too

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1765#pullrequestreview-156542883