Re: [quicwg/base-drafts] Out of order relative to other ack-eliciting packets (#4000)

ianswett <notifications@github.com> Sun, 16 August 2020 19:58 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF2083A10E7 for <quic-issues@ietfa.amsl.com>; Sun, 16 Aug 2020 12:58:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.009
X-Spam-Level:
X-Spam-Status: No, score=-2.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZH5BjcJyY9VJ for <quic-issues@ietfa.amsl.com>; Sun, 16 Aug 2020 12:58:39 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EC48A3A10E5 for <quic-issues@ietf.org>; Sun, 16 Aug 2020 12:58:38 -0700 (PDT)
Received: from github-lowworker-fb56993.ac4-iad.github.net (github-lowworker-fb56993.ac4-iad.github.net [10.52.19.31]) by smtp.github.com (Postfix) with ESMTP id 39497600D9D for <quic-issues@ietf.org>; Sun, 16 Aug 2020 12:58:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597607918; bh=c7zIYo6U76y8rDwELBv0bhgu3fbVCInBPA/jF1GVZHA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=u+te3kcYT2OyIxCQ2/UqRwGFW3ZjN3DTNLfO8BV6Bce52l3bFPBy5smYayfd+4sgD cNUd1GZsHn47M+WB1ANNINUiH+lKwEg+oQNMplpukqSDg4eDJgCcZEAsPaRfH7ytiH s/GWD5d6O3MXmqWh0jpQN8y/Wqzca2QzidUA91Hs=
Date: Sun, 16 Aug 2020 12:58:38 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7UUOSOYCMB6WEME255IVYO5EVBNHHCRBJDQE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4000/c674570627@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4000@github.com>
References: <quicwg/base-drafts/pull/4000@github.com>
Subject: Re: [quicwg/base-drafts] Out of order relative to other ack-eliciting packets (#4000)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f398fee2933a_79781964101542a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/x5DLViBcAVxIagb8k_AzVPK8YuQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Aug 2020 19:58:41 -0000

The code that sends ACK frames would track the largest received ack-eliciting packet to determine if packets are out of order, not the largest received packet.

This is similar to PTO, which is armed from the largest ack-eliciting packet, not the largest packet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4000#issuecomment-674570627