Re: [quicwg/base-drafts] Clarify zero-length CIDs and active_connection_id_limit TP (#3426)

Martin Thomson <notifications@github.com> Wed, 05 February 2020 16:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A4259120815 for <quic-issues@ietfa.amsl.com>; Wed, 5 Feb 2020 08:42:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6PMKmSRubijr for <quic-issues@ietfa.amsl.com>; Wed, 5 Feb 2020 08:42:15 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8506312080E for <quic-issues@ietf.org>; Wed, 5 Feb 2020 08:42:15 -0800 (PST)
Received: from github-lowworker-a6a2749.va3-iad.github.net (github-lowworker-a6a2749.va3-iad.github.net [10.48.16.62]) by smtp.github.com (Postfix) with ESMTP id 4E6C76606B7 for <quic-issues@ietf.org>; Wed, 5 Feb 2020 08:42:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1580920934; bh=Ys2d9sIuc+ct2EihSceo4EvkOOQVwBq4wJoKrBszg+Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=N4MLwuYe/2ji8X9nUq6umIAdr+EQMn9JoLXXAFecwd1d5P1wcn/evbFfo3kLWxcLV i2fObDsdxe1QttsY48Qa9Ll26dqGfImCEtjPOQdj1p4VQbiU6tq9zYexMQ7f399DfV 3u2oCTa7LBP/mJT3meAvLYdESngqlr3Y1WjSOLmg=
Date: Wed, 05 Feb 2020 08:42:14 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYAEAVJP5ATG4WPRHV4JARONEVBNHHCCZ7YJA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3426/review/353867016@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3426@github.com>
References: <quicwg/base-drafts/pull/3426@github.com>
Subject: Re: [quicwg/base-drafts] Clarify zero-length CIDs and active_connection_id_limit TP (#3426)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e3af0663ec85_2a5b3fead96cd9603048e7"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/x6maoc8jtuQ_a6O4YG-nyAHHuX8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Feb 2020 16:42:17 -0000

martinthomson requested changes on this pull request.

I think that I have larger concerns than this addresses. The special case for the server only highlighted that.   

>    active_connection_id_limit parameter MUST be no less than 2. If this
-  transport parameter is absent, a default of 2 is assumed.
-  When a zero-length connection ID is being used, the active_connection_id_limit
-  parameter MUST NOT be sent.
+  transport parameter is absent, a default of 2 is assumed.  When the client
+  is using a zero-length connection ID, the server MUST NOT send the
+  active_connection_id_limit parameter.

I would say here that the server MAY omit the parameter.  Sending a fixed set of transport parameters is a good practice. 

> @@ -4697,11 +4697,11 @@ active_connection_id_limit (0x000e):
   to store. This value includes the connection ID received during the handshake,
   that received in the preferred_address transport parameter, and those received
   in NEW_CONNECTION_ID frames.
-  Unless a zero-length connection ID is being used, the value of the
+  Unless the peer is using a zero-length connection ID, the value of the

I would instead prefer to say that the value is assumed to be zero if the peer requests that a zero length CID be used.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3426#pullrequestreview-353867016