IETF Logo Mail Archive

Re: [quicwg/base-drafts] extended unidirectional streams can be closed or reset (#2332)

Mike Bishop <notifications@github.com> Mon, 14 January 2019 17:46 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD25C1311FF for <quic-issues@ietfa.amsl.com>; Mon, 14 Jan 2019 09:46:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.149
X-Spam-Level:
X-Spam-Status: No, score=-6.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sn6LxRZiD7Iz for <quic-issues@ietfa.amsl.com>; Mon, 14 Jan 2019 09:46:35 -0800 (PST)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A3F221286E7 for <quic-issues@ietf.org>; Mon, 14 Jan 2019 09:46:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=tmOGBvfPfoqF9n8m2p8u9cTUkWA=; b=C0n6yZOmKaKCe83i m3hPRVcWfvUgP1nkyVOpEPFvdLF+RCBIHxLf13rZX7uK1B/qA0LgPIZwninU1VM1 Cn0Tl8LQwoV8HlEU/Gm5Q8atueoThNCf5fSvGEQ44EVstf3qizE9sNc0Y6GSvf+V c7/HvCPIgOqEdBa+6Bh4cQ6bNPI=
Received: by filter1725p1mdw1.sendgrid.net with SMTP id filter1725p1mdw1-15824-5C3CCAF9-10 2019-01-14 17:46:33.288495914 +0000 UTC m=+2905.136624668
Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0036p1iad2.sendgrid.net (SG) with ESMTP id 5KmXlF2_ROC_lAffyQUDCw for <quic-issues@ietf.org>; Mon, 14 Jan 2019 17:46:33.275 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id 3F3793E008A for <quic-issues@ietf.org>; Mon, 14 Jan 2019 09:46:33 -0800 (PST)
Date: Mon, 14 Jan 2019 17:46:33 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe8c1fe956fa47c6b37bbdac1588bf73c00524d3792cf0000000118548cf992a169ce17c24237@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2332/review/192276265@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2332@github.com>
References: <quicwg/base-drafts/pull/2332@github.com>
Subject: Re: [quicwg/base-drafts] extended unidirectional streams can be closed or reset (#2332)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3ccaf93dda1_39b93fab00cd45c06392d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2Yy2a3+QBZuunofbdQbeFt1KG/4WDYfIptqk pFTO2BFCuQRZltVDcuggAjrcGdB/nRDEjsm6R8r/o1dR1DhbYvOHgqgRxdPuMwWboT07JIvXILzfj8 MLOGLv45yKHu0BOhc4QajyBjMVhtgT+OJPI7JMGGLpu9QyMBiQknGsQlKwpiOlTGNToOHT83L+kmwu 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xA55jwEbRXIZKdkTZI7YjBt9CgU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jan 2019 17:46:43 -0000

MikeBishop approved this pull request.

Looks good.

> @@ -334,6 +334,10 @@ them.  However, stream types which could modify the state or semantics of
 existing protocol components, including QPACK or other extensions, MUST NOT be
 sent until the peer is known to support them.
 
+A sender can close or reset a unidirectional stream unless specified otherwise.

```suggestion
A sender can close or reset a unidirectional stream unless otherwise specified.
```
This is the more usual word ordering, though I admit I don't know why.  :-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2332#pullrequestreview-192276265

v2.23.0 | Report a Bug | By Email