Re: [quicwg/base-drafts] Default settings in HTTP (#2038)

Mike Bishop <notifications@github.com> Tue, 27 November 2018 19:58 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E7931124D68 for <quic-issues@ietfa.amsl.com>; Tue, 27 Nov 2018 11:58:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p0qy1wwF59xt for <quic-issues@ietfa.amsl.com>; Tue, 27 Nov 2018 11:58:44 -0800 (PST)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4E9161241F6 for <quic-issues@ietf.org>; Tue, 27 Nov 2018 11:58:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=CJ8ifaym+sVSeX94tk/Znn2WJ2Q=; b=H3iB6wxteIxR0OSH XtuvQYykKwAOqMWce4sxQda7fEosazY4Pl0A61wyzoThtZ/Axl0GSebHJsDhBDgu nVfZlrizaCLwjOwPzfcYeVQsY2uFfLPSI8RoWByYBY1WALK4ppFeAUUGRhs0Lnzj Qc9AMFmHh+tTGpVnD1Skd9tCskc=
Received: by filter0769p1las1.sendgrid.net with SMTP id filter0769p1las1-16094-5BFDA1F2-7 2018-11-27 19:58:42.369163334 +0000 UTC m=+1027575.067655687
Received: from github-lowworker-3c598a3.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0015p1iad2.sendgrid.net (SG) with ESMTP id 2v1ZliEAQgyh5d9QhEDWgg for <quic-issues@ietf.org>; Tue, 27 Nov 2018 19:58:42.381 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-3c598a3.cp1-iad.github.net (Postfix) with ESMTP id 3DFC3A802A8 for <quic-issues@ietf.org>; Tue, 27 Nov 2018 11:58:42 -0800 (PST)
Date: Tue, 27 Nov 2018 19:58:42 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab623ec729da6917c15940765f318aba41e0a37d0a92cf00000001181563f292a169ce16d8e664@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2038/review/178980962@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2038@github.com>
References: <quicwg/base-drafts/pull/2038@github.com>
Subject: Re: [quicwg/base-drafts] Default settings in HTTP (#2038)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfda1f23c7a6_34a13fdba1ed45c42194b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3xbKOiMAPRDlTcZJQ0FTFxKmdNbeDA+WKR9B Jic9DVpmUdil5BUrB4QxG86RiKGt4bK7k/1fsDfQo9dQIsDEMVfropEzcIAtl8dBe7crkLHONNouvc KNGHh58MvWF2ULcu4EfyunoErOQA5ymJ2Gys6hiMLHWUKXtxm3pgB5uVrwguI4Hrw61ddX1V5QNtC3 s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xATi5FoIBAXEK0wNnwhKLE1lliY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Nov 2018 19:58:46 -0000

MikeBishop commented on this pull request.



> @@ -1014,12 +1014,12 @@ represented as an 8-bit prefix string literal.
 QPACK defines two settings which are included in the HTTP/QUIC SETTINGS frame.
 
   SETTINGS_HEADER_TABLE_SIZE (0x1):
-  : An integer with a maximum value of 2^30 - 1.  The default value is 4,096
+  : An integer with a maximum value of 2^30 - 1.  The default value is zero
     bytes.  See {{table-dynamic}} for usage.

Also, it appears that @martinthomson's change to replace octets with bytes last month was global, so that text doesn't match the current editor's copy of QPACK.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2038#discussion_r236824029