Re: [quicwg/base-drafts] Congestion window reduced on ACK (#2244)

ianswett <notifications@github.com> Fri, 21 December 2018 21:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D1086130E95 for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 13:26:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F_TLUE8gHyGL for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 13:26:17 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 09F20130F27 for <quic-issues@ietf.org>; Fri, 21 Dec 2018 13:26:17 -0800 (PST)
Date: Fri, 21 Dec 2018 13:26:16 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545427576; bh=BZFqAGgODI+CbdqmGhbA2iiCHQsufJbuTlTvJAxy4Q8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eiY0/JJ58SEPaAxaacp7ZZ9QUQoliuxMB7cwoqNWCoikMkt1zirU/ffGRIYFds7xi xCuCfzu0NqLGoCsstc+5zBzCFEy/746AJ4lsMA3ktiuwx1veCrVy/CDm3UApnf1fdL QvgfYuWRbGBObEo9ycf2V5UAqLfFyBKPHxEGSCPQ=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfade70f17363af9f40ea6cb8962b166e4b72ee7e92cf0000000118351c7892a169ce177596a6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2244/review/187543129@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2244@github.com>
References: <quicwg/base-drafts/pull/2244@github.com>
Subject: Re: [quicwg/base-drafts] Congestion window reduced on ACK (#2244)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1d5a781ad50_3d83fb0278d45c0140c0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xAbQbtg6GAkGYxG-FmZ4r5vP1JM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2018 21:26:24 -0000

ianswett commented on this pull request.



> @@ -1023,15 +1027,13 @@ kLossReductionFactor:
   The RECOMMENDED value is 0.5.
 
 kPersistentCongestionThreshold:
-: Number of consecutive PTOs after which network is considered to be
+: Number of consecutive PTOs after which network might be considered to be

I think "considered" is sufficient.  Might be considered is double vague in my opinion. 

But considered isn't great anyway.  Maybe "Number of consecutive PTOs after which the congestion controller assumes persistent congestion."?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2244#discussion_r243695670