IETF Logo Mail Archive

Re: [quicwg/base-drafts] New connection IDs are mandatory for intentional migration (#2414)

ianswett <notifications@github.com> Fri, 08 February 2019 16:23 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2DDE4130E82 for <quic-issues@ietfa.amsl.com>; Fri, 8 Feb 2019 08:23:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pbzKPk6LwBk3 for <quic-issues@ietfa.amsl.com>; Fri, 8 Feb 2019 08:23:25 -0800 (PST)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 65D23130DC9 for <quic-issues@ietf.org>; Fri, 8 Feb 2019 08:23:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=G6c9aLhAEoDT8bdk45w5BHlwjV4=; b=D4ikB9v1pVWoWzt+ 26sK+PszJMOWTBhfHNe6SFBFRLnBFRLXQwb8n+exrepcWH+jfP4a8vPqwRBnz0SB 7gay31sMxYlI8eIU6SZrEfvCVDQ1TtRwo3LP2oHWVPMjamwwsLkTsFcANTVSHBJh CG/ySEENInXFcG+W5e4bz/bXRz0=
Received: by filter1195p1las1.sendgrid.net with SMTP id filter1195p1las1-16229-5C5DACF9-36 2019-02-08 16:23:21.872122452 +0000 UTC m=+239259.491984141
Received: from github-lowworker-1f7e42f.cp1-iad.github.net (unknown [192.30.252.46]) by ismtpd0035p1iad2.sendgrid.net (SG) with ESMTP id UqlCcMjqRgqIbvKbm7VYkg for <quic-issues@ietf.org>; Fri, 08 Feb 2019 16:23:21.773 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1f7e42f.cp1-iad.github.net (Postfix) with ESMTP id BF794C0351 for <quic-issues@ietf.org>; Fri, 8 Feb 2019 08:23:21 -0800 (PST)
Date: Fri, 08 Feb 2019 16:23:22 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abddd4df1e552a7420b696815eadf4e4c9dbf46d7792cf0000000118756ef992a169ce183ba47d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2414/review/201664446@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2414@github.com>
References: <quicwg/base-drafts/pull/2414@github.com>
Subject: Re: [quicwg/base-drafts] New connection IDs are mandatory for intentional migration (#2414)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5dacf9bd5ab_69623f8b9ccd45bc154157"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0DU2B9/0jOabg0dNfBktHmnD1jXrw9EIkfm8 EjcDohPmcAQKA8T02i+Gd7JJfLZCggsknCLK+DYLU/BeJokcSzBt87wNP69wyRdSDW2DT46D7InQHZ u2Su/DkmZqIIORUTxsQpftRKIlM0KDIV8gxsaXrHcO6XD2ipfXg4+w/gRxhokas97QOHt2Nt7ydJd9 U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xI0wML6q1NR-eA72hOznrYRsfQI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Feb 2019 16:23:35 -0000

ianswett commented on this pull request.



> @@ -1853,7 +1853,9 @@ An endpoint also MUST NOT initiate connection migration if the peer sent the
 `disable_migration` transport parameter during the handshake.  An endpoint which
 has sent this transport parameter, but detects that a peer has nonetheless
 migrated to a different network MAY treat this as a connection error of type
-INVALID_MIGRATION.
+INVALID_MIGRATION.  Similarly, an endpoint MUST NOT migrate if its peer supplies

As I said on the list, I'm not a big fan of adding this 0-len CID restriction.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2414#pullrequestreview-201664446

v2.23.0 | Report a Bug | By Email