IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make language in ECN validation clearer (#3777)

Martin Thomson <notifications@github.com> Thu, 18 June 2020 06:04 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B9AE43A0E91 for <quic-issues@ietfa.amsl.com>; Wed, 17 Jun 2020 23:04:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.009
X-Spam-Level:
X-Spam-Status: No, score=-2.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U4zrMGdKP4la for <quic-issues@ietfa.amsl.com>; Wed, 17 Jun 2020 23:04:38 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8C3A93A0D19 for <quic-issues@ietf.org>; Wed, 17 Jun 2020 23:04:38 -0700 (PDT)
Received: from github-lowworker-5fb2734.va3-iad.github.net (github-lowworker-5fb2734.va3-iad.github.net [10.48.19.27]) by smtp.github.com (Postfix) with ESMTP id B2FBC8C12A3 for <quic-issues@ietf.org>; Wed, 17 Jun 2020 23:04:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1592460277; bh=Tk8/dqWzrIsBZM8ca3m6k5NUpebzzMa5mKBPKulfgCg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=D5Oy4LYJDQoUQp6U901KjlALGh09xH8A+OgoPq+B8J2CUYXX76tebi/c97UpKPuJU QveZiFMk34zbj8mLHkJp0rSGAAQrKPW+7BB1M0s/bJflkCb1xMih+KkxbKcSdDnPcX CYFqfBNxpnAJWAtgnHIuotC3rbw9ubFX6P3bD/kA=
Date: Wed, 17 Jun 2020 23:04:37 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5RBVGOH4JLP5J2DLN463SPLEVBNHHCMM6BII@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3777/c645791453@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3777@github.com>
References: <quicwg/base-drafts/pull/3777@github.com>
Subject: Re: [quicwg/base-drafts] Make language in ECN validation clearer (#3777)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5eeb03f5a3f19_ac33f9cabccd9686945c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xIChkxqY8u8lGwjmNWLZheOvmQg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2020 06:04:40 -0000

OK, I realize now my mistake.  The draft allows for an increase because of the possibility of ACK loss.  Counts might increase more than there are newly acknowledged packets because an endpoint might not receive an ACK for every packet that is accounted for in the increased count.  I think that's worth a note.  

Though now I'm concerned about the third clause, which doesn't include any protection against this problem.  I'll open an issue for that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3777#issuecomment-645791453

v2.40.3 | Report a Bug | By Email | System Status