[quicwg/base-drafts] fb6470: Pseudocode for persistent congestion is too hard

Jana Iyengar <noreply@github.com> Tue, 08 September 2020 22:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9E2CD3A0808 for <quic-issues@ietfa.amsl.com>; Tue, 8 Sep 2020 15:56:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.101
X-Spam-Level:
X-Spam-Status: No, score=-2.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TKinulRlBbZZ for <quic-issues@ietfa.amsl.com>; Tue, 8 Sep 2020 15:56:00 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2CD2E3A08BB for <quic-issues@ietf.org>; Tue, 8 Sep 2020 15:56:00 -0700 (PDT)
Received: from github-lowworker-b2150d3.ash1-iad.github.net (github-lowworker-b2150d3.ash1-iad.github.net [10.56.113.12]) by smtp.github.com (Postfix) with ESMTP id 780FA900062 for <quic-issues@ietf.org>; Tue, 8 Sep 2020 15:55:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1599605759; bh=atxW+7uKH2eKrqZ3LdV/nKoXWEUOGgxOK6nXouFkBSE=; h=Date:From:To:Subject:From; b=yT1Md3Ls1Q6GwlbjEPnJnPPQfvmS4XlEpPSTNRnv6rjML9nzVniypNoHkB+nw1S/h BN3pruJf0pOYY20HIRiweQN5ErtK0xvGhv9RKrYfxnbF+fn99fNT/PBLJBJHZ0Tez+ BskeFlpE0jaLOSV0dllepxIPCJqZK34ql339iLD4=
Date: Tue, 08 Sep 2020 15:55:59 -0700
From: Jana Iyengar <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/master/3f5f19-f57edf@github.com>
Subject: [quicwg/base-drafts] fb6470: Pseudocode for persistent congestion is too hard
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xILqzNIc6AOwYxVWIpcm4KOLS64>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Sep 2020 22:56:08 -0000

  Branch: refs/heads/master
  Home:   https://github.com/quicwg/base-drafts
  Commit: fb64708249f8e089121082ba0de6e4cd0c6648c1
      https://github.com/quicwg/base-drafts/commit/fb64708249f8e089121082ba0de6e4cd0c6648c1
  Author: Martin Thomson <mt@lowentropy.net>
  Date:   2020-09-02 (Wed, 02 Sep 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Pseudocode for persistent congestion is too hard

This removes that function, relying instead on comments and the
definition in text (which people have noted is now very clear).

I have also reset a couple of extra variables in this case.  It is
important to catch all of these because if you don't you get poor
outcomes.

The only question I have is regarding bytes in flight.  I think that we
need to keep tracking those bytes, or the overall accounting gets messy.
That is what our implementation does anyway.

Closes #4010.
Closes #3972.


  Commit: a8adc5d8d5ccab2cb05dc3a371057c71df275a76
      https://github.com/quicwg/base-drafts/commit/a8adc5d8d5ccab2cb05dc3a371057c71df275a76
  Author: Martin Thomson <mt@lowentropy.net>
  Date:   2020-09-09 (Wed, 09 Sep 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  oops


  Commit: 779d9238f65c3373619615b3b05257196e811e8a
      https://github.com/quicwg/base-drafts/commit/779d9238f65c3373619615b3b05257196e811e8a
  Author: Martin Thomson <mt@lowentropy.net>
  Date:   2020-09-09 (Wed, 09 Sep 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Filter out packets sent before an RTT sample


  Commit: 20642c995d59efe11f6c5fbb575aa130e72f73f7
      https://github.com/quicwg/base-drafts/commit/20642c995d59efe11f6c5fbb575aa130e72f73f7
  Author: Martin Thomson <mt@lowentropy.net>
  Date:   2020-09-09 (Wed, 09 Sep 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Make a copy for this


  Commit: 71c232f81b377fad180d24e3a19efe256e595725
      https://github.com/quicwg/base-drafts/commit/71c232f81b377fad180d24e3a19efe256e595725
  Author: Martin Thomson <mt@lowentropy.net>
  Date:   2020-09-09 (Wed, 09 Sep 2020)

  Changed paths:
    M draft-ietf-quic-http.md
    M draft-ietf-quic-recovery.md
    M draft-ietf-quic-tls.md
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Merge branch 'master' into no-pc-pseudocode


  Commit: c4bd59fee3d0c7b7d6508403d7b7b627b94eeb19
      https://github.com/quicwg/base-drafts/commit/c4bd59fee3d0c7b7d6508403d7b7b627b94eeb19
  Author: Martin Thomson <mt@lowentropy.net>
  Date:   2020-09-09 (Wed, 09 Sep 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Copy inline


  Commit: 9c2d7fb58100b6519a5d3fb523541c98d939cbcf
      https://github.com/quicwg/base-drafts/commit/9c2d7fb58100b6519a5d3fb523541c98d939cbcf
  Author: Martin Thomson <mt@lowentropy.net>
  Date:   2020-09-09 (Wed, 09 Sep 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  curlies


  Commit: 900535aec0ef510a8cac858ef4a7a17055467656
      https://github.com/quicwg/base-drafts/commit/900535aec0ef510a8cac858ef4a7a17055467656
  Author: Martin Thomson <mt@lowentropy.net>
  Date:   2020-09-09 (Wed, 09 Sep 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Invert comment


  Commit: f57edfa2355f1ccc0857d7755b9854762325721d
      https://github.com/quicwg/base-drafts/commit/f57edfa2355f1ccc0857d7755b9854762325721d
  Author: Jana Iyengar <jri.ietf@gmail.com>
  Date:   2020-09-08 (Tue, 08 Sep 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Merge pull request #4080 from quicwg/no-pc-pseudocode

Pseudocode for persistent congestion is too hard


Compare: https://github.com/quicwg/base-drafts/compare/3f5f1991a299...f57edfa2355f