IETF Logo Mail Archive

Re: [quicwg/base-drafts] Prohibit reading 1-RTT before handshake complete (#3868)

Jana Iyengar <notifications@github.com> Mon, 27 July 2020 23:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 741FB3A0407 for <quic-issues@ietfa.amsl.com>; Mon, 27 Jul 2020 16:38:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DUwN9QvyUsfA for <quic-issues@ietfa.amsl.com>; Mon, 27 Jul 2020 16:38:50 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 427263A03F6 for <quic-issues@ietf.org>; Mon, 27 Jul 2020 16:38:50 -0700 (PDT)
Received: from github-lowworker-edec459.ac4-iad.github.net (github-lowworker-edec459.ac4-iad.github.net [10.52.18.32]) by smtp.github.com (Postfix) with ESMTP id DC0305C0E15 for <quic-issues@ietf.org>; Mon, 27 Jul 2020 16:38:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595893128; bh=37v0aTnfI3fnRFWv+aT4umxtEPazHOTCt7PUVjn7AvQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RmLgIElXGrnr+mgSYd1Whs+nQM1+yYY25In/BEMOXneXpiihmvH5ZgKTqg2NJuHKG oOD4Z+RqPWET2YhFTxBXFAFgYnshsegkAv4bP1ap8a5XsTQirAxI6RFGPXQlZuqyhh tDKk6OOhWIREYLZ58CZ+DIpOMlp5SeXSO0VYK0bA=
Date: Mon, 27 Jul 2020 16:38:48 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3OFTF46ZZV33HCJY55FNDIREVBNHHCN3BEFQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3868/review/456205888@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3868@github.com>
References: <quicwg/base-drafts/pull/3868@github.com>
Subject: Re: [quicwg/base-drafts] Prohibit reading 1-RTT before handshake complete (#3868)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f1f6588cc500_35703f9880ecd968872cd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xN0Ow1mF13Z--04L-Vkph4dtsSg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jul 2020 23:38:54 -0000

@janaiyengar commented on this pull request.



> @@ -1280,6 +1280,10 @@ A server could receive packets protected with 0-RTT keys prior to receiving a
 TLS ClientHello.  The server MAY retain these packets for later decryption in
 anticipation of receiving a ClientHello.
 
+A client generally receives 1-RTT keys at the same time as the handshake
+completes.  However, a client also MUST NOT process incoming 1-RTT protected
+packets before the TLS handshake is complete.

Some editorializing might help. How about "Even if it has 1-RTT keys, a client MUST NOT .."

> +Therefore, the server's use of 1-RTT keys is limited to sending data before
 the handshake is complete.  A server MUST NOT process incoming 1-RTT protected

```suggestion
Therefore, the server's use of 1-RTT keys before the handshake is complete is
limited to sending data.  A server MUST NOT process incoming 1-RTT protected
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3868#pullrequestreview-456205888

v2.29.0 | Report a Bug | By Email | System Status