Re: [quicwg/base-drafts] Closing and draining tidy (#3988)
Martin Thomson <notifications@github.com> Tue, 11 August 2020 01:49 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 21F373A0EB2 for <quic-issues@ietfa.amsl.com>; Mon, 10 Aug 2020 18:49:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nDmExc6X_PEB for <quic-issues@ietfa.amsl.com>; Mon, 10 Aug 2020 18:48:58 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B249B3A0EA7 for <quic-issues@ietf.org>; Mon, 10 Aug 2020 18:48:58 -0700 (PDT)
Received: from github-lowworker-275fa97.va3-iad.github.net (github-lowworker-275fa97.va3-iad.github.net [10.48.17.64]) by smtp.github.com (Postfix) with ESMTP id C9AA4340D45 for <quic-issues@ietf.org>; Mon, 10 Aug 2020 18:48:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597110537; bh=1SnuzRoOrpGSDvaK4gt5r1RmmF2FZ+ywKCdCbX5frtc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SdNKGCtmu2R3aZ32S15/dsVC9/BvxQk6FVwdgnlqgw8fwI60TuZQAo9bIQGlWoVPZ U87r3M5q/65raXO891fU+UdhikaKb5wgAqHM0udnpbJISMs/0X+wfKq7ED/fRFfDMl CFyM3xJ6MCaoeH7Bu3cOwQ5FFyvjAceZcPVey+AE=
Date: Mon, 10 Aug 2020 18:48:57 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK75OYUAUTEKVWENZ4N5HXNATEVBNHHCQLL6RE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3988/review/464694590@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3988@github.com>
References: <quicwg/base-drafts/pull/3988@github.com>
Subject: Re: [quicwg/base-drafts] Closing and draining tidy (#3988)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f31f909b9d13_441216f89014"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xRn6ld_qS28jdLpPHDpPsFbt2tg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Aug 2020 01:49:00 -0000
@martinthomson commented on this pull request.
Thanks Ian, I took the suggestions. Not sure about the reordering thing.
> +
+An immediate close can be used after an application protocol has arranged to
+close a connection. This might be after the application protocols negotiates a
+graceful shutdown. The application protocol exchanges whatever messages that
+are needed to cause both endpoints to agree to close the connection, after which
+the application requests that the connection be closed. When the application
+closes the connection, a CONNECTION_CLOSE frame with an appropriate error code
+will be used to signal closure.
+
+The closing and draining connection states exist to ensure that connections
+close cleanly and that delayed or reordered packets are properly discarded.
+These states SHOULD persist for at least three times the current Probe Timeout
+(PTO) interval as defined in {{QUIC-RECOVERY}}.
+
+Disposing of connection state prior to the exiting the closing or draining state
+could cause delayed or reordered packets to generate an unnecessary stateless
Let's say that you send CONNECTION_CLOSE then drop state immediately. It's not clear whether packets you subsequently receive are the result of the peer just sending, delays, or reordering. Maybe we can just say "packets":
> [...] could result in an generating unnecessary stateless reset in response to receiving a packet.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3988#pullrequestreview-464694590
- [quicwg/base-drafts] Closing and draining tidy (#… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Nick Banks
- Re: [quicwg/base-drafts] Closing and draining tid… ianswett
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… ianswett
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… ianswett
- Re: [quicwg/base-drafts] Closing and draining tid… Mike Bishop
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Jana Iyengar
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Martin Thomson
- Re: [quicwg/base-drafts] Closing and draining tid… Jana Iyengar
- Re: [quicwg/base-drafts] Closing and draining tid… Jana Iyengar