[quicwg/base-drafts] PTO pseudocode should not arm the timer for PN spaces with no bytes in flight (#3674)
ianswett <notifications@github.com> Wed, 20 May 2020 02:10 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 813843A08E4 for <quic-issues@ietfa.amsl.com>; Tue, 19 May 2020 19:10:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8I2HvJpmPkXX for <quic-issues@ietfa.amsl.com>; Tue, 19 May 2020 19:10:00 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 027E83A040F for <quic-issues@ietf.org>; Tue, 19 May 2020 19:09:59 -0700 (PDT)
Received: from github-lowworker-2300405.va3-iad.github.net (github-lowworker-2300405.va3-iad.github.net [10.48.17.39]) by smtp.github.com (Postfix) with ESMTP id 6253DA04A1 for <quic-issues@ietf.org>; Tue, 19 May 2020 19:09:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589940598; bh=znN43nVfRxNUQ5uf/+RwsMkCSh6Yl/lSAhbijfZH5wI=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=Yx6ktVKS30QOEvVOlNIKM7NuzzTfMLefwsvOHAw70xBCMvhr6eoi0eKUCFCoXrItR vs5YhiH3vUx9iEmpsIoKVojtSiWLaE2iS5Gp2ZvcHZ8AO0QttO5Lm0G9p4AgTHkxTJ Sd+/jQkAdXQnhTIaAJ6wEIljQFKOh7I5EYpVnYY4=
Date: Tue, 19 May 2020 19:09:58 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK57CQBTA32TDKXW4GF42BZHNEVBNHHCKCPB6Y@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3674@github.com>
Subject: [quicwg/base-drafts] PTO pseudocode should not arm the timer for PN spaces with no bytes in flight (#3674)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ec491765306a_98f3f9abaecd968509799"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xSesAJZgN1BXwvn9oXEM3Nw32rg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 May 2020 02:10:02 -0000
The text is fairly clear that PTO is armed for PN spaces with in-flight packets, but the pseudocode for arming the PTO has no consideration for whether there are bytes in flight in that PN space, and instead only considers the last sent packet in a PN space. I believe the easiest solution is to add a bytes_in_flight indexed by PN space and then checking it in GetEarliestTimeAndSpace(or whatever replaces it) when deciding whether to arm the PTO. https://github.com/quicwg/base-drafts/blob/master/draft-ietf-quic-recovery.md#setting-the-loss-detection-timer -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/3674