IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add Definitions (#1557)

Martin Thomson <notifications@github.com> Sat, 14 July 2018 21:20 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0FB49130E91 for <quic-issues@ietfa.amsl.com>; Sat, 14 Jul 2018 14:20:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vB7DiW07SYnb for <quic-issues@ietfa.amsl.com>; Sat, 14 Jul 2018 14:20:56 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12A6D126BED for <quic-issues@ietf.org>; Sat, 14 Jul 2018 14:20:56 -0700 (PDT)
Date: Sat, 14 Jul 2018 14:20:55 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531603255; bh=NYnVRxSBe5JyJi6XKe8engqjF/ozwTS4QihwKMBWbro=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=em1NQ9BcIeljUiZOjqkYz3cJcNo55B6VjZPx7VDN/Xaly1vz8ACAIwbr+Fyx81V4f nREo6Wd5awU6GjiXeSqj/Xk+OGRn80V0ry7qy10DWBBfsZ704hfeUU0f8f7upjhHwx 51FZYP8gb2yN2NzXEvUvbuVd7npDYSxyGfVfk3ZM=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab03ffa3759c7e6482f59f8caebaf0e4f509ef218c92cf0000000117622b3792a169ce1456e92b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1557/review/137248862@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1557@github.com>
References: <quicwg/base-drafts/pull/1557@github.com>
Subject: Re: [quicwg/base-drafts] Add Definitions (#1557)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4a69376e316_734b3fdfc0266f8044108f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xTqHXBpM88kueTHQi0iYLtt9Ciw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jul 2018 21:20:58 -0000

martinthomson approved this pull request.



> +
+In-flight:
+
+: Packets are considered in-flight when they have been sent
+  and neither acknowledged or declared lost, and they are not
+  ACK-only.
+
+Retransmittable Frames:
+
+: All frames besides ACK, ACK_ECN, or PADDING are considered
+  retransmittable.
+
+Retransmittable Packets:
+
+: Packets that contain retransmittable frames elicit an ACK from
+  the receiver and are called retransmittable packets.

Both packets and frames aren't classified as retransmittable or not.  It would be better if this used a different label.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1557#pullrequestreview-137248862

v2.31.3 | Report a Bug | By Email | System Status