IETF Logo Mail Archive

Re: [quicwg/base-drafts] Reorganize ACK section (#2197)

janaiyengar <notifications@github.com> Tue, 08 January 2019 01:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0997D130E08 for <quic-issues@ietfa.amsl.com>; Mon, 7 Jan 2019 17:19:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eVxqwwJGPzFn for <quic-issues@ietfa.amsl.com>; Mon, 7 Jan 2019 17:19:22 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4CDCF12008A for <quic-issues@ietf.org>; Mon, 7 Jan 2019 17:19:22 -0800 (PST)
Date: Mon, 07 Jan 2019 17:19:21 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546910361; bh=hZzhmOz8g2YtoAjRhEbT6ghi68Ossqzec1XIHq1lUQQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=C5bsK5zBiHZVCGirwxeB1WzITJbC9TnngDnIHVYLw7sX/XXc0YNTC2SCvirtD188K /VhgtKY1VGVl7iQcJBNlN+FLei2HNl2aWq6laR3K3WytMUPSX/Mnugd0dajQg2UoR6 x6KJTdmTi/WLvMrYXvcNOaGoibmQp6go/kACjbFU=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abbf6d01ecbe81e40a262739bdac4ab0fbde8c4a3892cf00000001184bbc9992a169ce17565ed9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2197/review/190060974@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2197@github.com>
References: <quicwg/base-drafts/pull/2197@github.com>
Subject: Re: [quicwg/base-drafts] Reorganize ACK section (#2197)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c33fa9972f3b_7e523fd10dcd45c41223044"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xUPQAGqPRgcDE3aCGT_t6rsdUyw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 01:19:24 -0000

janaiyengar commented on this pull request.



>  
-
-### ECN section
+The ACK frame uses the least significant bit (that is, type 0x03) to indicate
+ECN feedback and report receipt of QUIC packets with associated ECN codepoints
+of ECT(0), ECT(1), or CE in the packet's IP header.  The ECN section is only
+present when the ACK frame type is 0x03.
 
 The ECN section should only be parsed when the ACK frame type is 0x03.  The ECN

```suggestion
ECN Counts should only be parsed when the ACK frame type is 0x03.  The ECN
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2197#pullrequestreview-190060974

v2.23.0 | Report a Bug | By Email